Page MenuHomeFreeBSD

xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c
ClosedPublic

Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 21, 3:48 PM
Unknown Object (File)
May 10 2024, 12:31 PM
Unknown Object (File)
May 5 2024, 5:02 AM
Unknown Object (File)
May 5 2024, 5:01 AM
Unknown Object (File)
Apr 29 2024, 4:25 AM
Unknown Object (File)
Apr 26 2024, 2:09 PM
Unknown Object (File)
Apr 24 2024, 11:57 PM
Unknown Object (File)
Apr 23 2024, 9:27 AM

Details

Summary

Minor changes are necessary to make this processor-independent, but
moving the file out of x86 and into common is the first step (so others
don't add /more/ x86-isms).

Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I would consider placing it in sys/dev/xen/bus/xenpv.c

Yeah, I've got no idea what-so-ever why one might feel xenpv.c should be
in a "bus" directory. No similarity to any type of bus. No devices
attached at all. Certainly not a bus.

Like so many comments, that one is pretty obvious when suggested.

Yeah, I've got no idea what-so-ever why one might feel xenpv.c should be
in a "bus" directory. No similarity to any type of bus. No devices
attached at all. Certainly not a bus.

I'm confused by the text above, do you agree it should be in a bus/ directory or not?

There are Xen devices (xen timer, xenstore) that attach to the xenpv bus.

I'm confused by the text above, do you agree it should be in a bus/ directory or not?

There are Xen devices (xen timer, xenstore) that attach to the xenpv bus.

My actual view should be reflected in the diff update. I went ahead and moved as requested. Felt like a 20/20 hindsight comment, it does look like a bus since it has devices attached and as such the idea is entirely reasonable.

ehem_freebsd_m5p.com retitled this revision from xen: move x86/xen/xenpv.c to dev/xen/xenpv.c to xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.Mar 4 2021, 9:48 PM
This revision is now accepted and ready to land.Mar 25 2021, 4:02 PM
This revision was automatically updated to reflect the committed changes.