Page MenuHomeFreeBSD

xen/intr: use __func__ instead of function names
ClosedPublic

Authored by ehem_freebsd_m5p.com on Mar 30 2021, 6:53 PM.

Details

Summary

Functions tend to get renamed and unless the developer is careful often
debugging messages are missed. As such using func is far superior.
Replace several instances of hard-coded function names.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Simply some cleanup. While working with this file I observed several functions hard-coding their names into messages.

If you are going to make changes to these KASSERTS, I feel it would be better if they had a consistent format of: __func__: message

sys/x86/xen/xen_intr.c
1279–1281

FreeBSD's style(9) prefers error != 0. Dropping the braces is fine.

I don't have a strong opinion on the rewording of the assert messages. @mhorne would you be OK if I commit this with the fixed error != 0 check?

This revision is now accepted and ready to land.Apr 6 2021, 2:49 PM

I don't have a strong opinion on the rewording of the assert messages. @mhorne would you be OK if I commit this with the fixed error != 0 check?

Sure, that's fine with me.