Page MenuHomeFreeBSD

xen/intr: move sys/x86/xen/xen_intr.c to sys/xen/xen_intr.c
Needs ReviewPublic

Authored by ehem_freebsd_m5p.com on May 12 2021, 9:37 PM.

Details

Reviewers
royger
mhorne
Summary

Major changes are necessary to make this processor-independent, but
moving the file out of x86 and into common is the first step (to preempt
addition of further x86-isms).

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-01-13 17:41:04

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 39148
Build 36037: arc lint + arc unit

Event Timeline

Any news on D30236?

From playing with this I'm wondering if perhaps this should instead move to sys/dev/xen/bus/intr.c instead. This file really looks like a combination of an interrupt controller and a small interface library. xen_intr_handle_upcall() is the call for servicing the interrupt on the system primary controller, which xen_intr.c then fans out to several software interrupts.

As a result this sort of acts like an interrupt controller associated with the xenpv bus. I'm wondering whether the Xen child devices should be allocating interrupts via the normal bus interface to xenpv.