Page MenuHomeFreeBSD

xen/control: print warning on call of xctrl_suspend()
ClosedPublic

Authored by ehem_freebsd_m5p.com on Apr 6 2021, 1:08 AM.
Tags
None
Referenced Files
F79484264: D29599.id.diff
Mon, Mar 18, 11:55 PM
Unknown Object (File)
Sat, Mar 2, 2:55 PM
Unknown Object (File)
Sat, Mar 2, 2:55 PM
Unknown Object (File)
Wed, Feb 28, 1:49 AM
Unknown Object (File)
Mon, Feb 19, 11:58 PM
Unknown Object (File)
Feb 18 2024, 8:22 AM
Unknown Object (File)
Dec 30 2023, 10:23 AM
Unknown Object (File)
Dec 30 2023, 10:23 AM

Details

Summary

Presently suspend/resume and migration aren't supported on Xen/ARM. As
such this shouldn't ever occur.

Modified to check for ARM instead of !x86, since ARM is where support is
missing. Other Xen architectures might get suspend support sooner.

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-01-13 17:41:15

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The commit message doesn't seem to match the actual code, it says: "implement suspend as panic for ARM" yet xctrl_suspend for Arm is just a printf, not a panic.

Hopefully arc grabs the updated commit message, though I suspect I'll
need to manually update the message in Phabricator.

ehem_freebsd_m5p.com retitled this revision from xen/control: implement suspend as panic for ARM to xen/control: print warning on call of xctrl_suspend().Apr 21 2021, 1:42 AM
ehem_freebsd_m5p.com edited the summary of this revision. (Show Details)

Hopefully the updated commit message is okay. That one was the original line, I hadn't been paying too close attention since issues hadn't focused here.

Switching back to checking for amd64 or i386. Likely
suspend/resume/migration won't immediately be supported for RISC-V.

Add machine/intr_machdep.h to guarded headers, this shouldn't be
#included in an architecture-independent file.

This revision is now accepted and ready to land.Apr 24 2021, 8:13 PM