Page MenuHomeFreeBSD

xen/control: print warning on call of xctrl_suspend()
AcceptedPublic

Authored by ehem_freebsd_m5p.com on Apr 6 2021, 1:08 AM.

Details

Reviewers
royger
mhorne
Summary

Presently suspend/resume and migration aren't supported on Xen/ARM. As
such this shouldn't ever occur.

Modified to check for ARM instead of !x86, since ARM is where support is
missing. Other Xen architectures might get suspend support sooner.

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-01-13 17:41:15

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 38348
Build 35237: arc lint + arc unit

Event Timeline

The commit message doesn't seem to match the actual code, it says: "implement suspend as panic for ARM" yet xctrl_suspend for Arm is just a printf, not a panic.

Hopefully arc grabs the updated commit message, though I suspect I'll
need to manually update the message in Phabricator.

ehem_freebsd_m5p.com retitled this revision from xen/control: implement suspend as panic for ARM to xen/control: print warning on call of xctrl_suspend().Wed, Apr 21, 1:42 AM
ehem_freebsd_m5p.com edited the summary of this revision. (Show Details)

Hopefully the updated commit message is okay. That one was the original line, I hadn't been paying too close attention since issues hadn't focused here.

Switching back to checking for amd64 or i386. Likely
suspend/resume/migration won't immediately be supported for RISC-V.

Add machine/intr_machdep.h to guarded headers, this shouldn't be
#included in an architecture-independent file.

This revision is now accepted and ready to land.Sat, Apr 24, 8:13 PM