Page MenuHomeFreeBSD

xen/control: introduce xen_pv_shutdown_handler()
ClosedPublic

Authored by ehem_freebsd_m5p.com on Mar 23 2021, 10:07 PM.

Details

Summary

While x86 only register PV shutdown handler for PV guests. ARM guests
are always using HVM and requires the PV shutdown handler.

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-04-04 16:52:05

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Just one minor comment.

sys/x86/include/xen/xen-os.h
52

Please drop the 'has' from the function name, as other similar functions just use xen_pv_foo format.

Removing the "has" from the function name as requested. Seems quite
appropriate.

Right place now. The difference should be sensible now.

ehem_freebsd_m5p.com retitled this revision from xen/control: introduce xen_has_pv_shutdown_handler() to xen/control: introduce xen_pv_shutdown_handler().Mar 30 2021, 7:02 PM
ehem_freebsd_m5p.com marked an inline comment as done.

Sorry about the bandwidth from all these small changes. Review systems really need to do a bit more batching for e-mail messages.

I discovered x86 needs D29811 first, but the requested change for D29406 has been done. Any news on this one?

This revision is now accepted and ready to land.Apr 21 2021, 7:40 AM