Page MenuHomeFreeBSD

xen/intr: merge parts of resume functionality into new function
ClosedPublic

Authored by ehem_freebsd_m5p.com on Jun 1 2021, 3:43 PM.
Tags
None
Referenced Files
F81695560: D30598.id92842.diff
Sat, Apr 20, 2:07 AM
F81689477: D30598.id92841.diff
Fri, Apr 19, 11:50 PM
F81684926: D30598.diff
Fri, Apr 19, 10:11 PM
F81666358: D30598.id91727.diff
Fri, Apr 19, 4:41 PM
Unknown Object (File)
Thu, Apr 18, 3:18 PM
Unknown Object (File)
Wed, Apr 17, 8:52 AM
Unknown Object (File)
Tue, Apr 16, 12:01 PM
Unknown Object (File)
Fri, Mar 29, 2:50 PM
Subscribers

Details

Summary

The portions of xen_rebind_ipi() and xen_rebind_virq() were already
near-identical. While xen_rebind_ipi() should panic() on
single-processor, still having the functionality to invoke seems
harmless.

Meanwhile much of the loop from xen_intr_resume() seemed to want to be
closer to this same code. This pushes related bits closer together.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fixing a bug which was found while glancing at this delta.

Removing one line which really should have been removed before.

Move the isrc->xi_cpu = 0; line lower, hopefully hinting this is part of the xen_intr_assign_cpu() call.

Small update, keep panic strings closer to original, but add function name. Should make diagnosis easier if this ever gets triggered.

Fix a potential unused variable warning. Single-processor systems almost seem archaic, but we should still function on such.

Remove a bit more unused in case of uniprocessor code from uniprocessor builds. Such are actually rather more sensible in case of virtual machines...

Ugh! Hopefully finish the hunt for bits which disappear if uniprocessor.

Fixing issue discovered during review. The blanket wipe of ->xi_port in xen_intr_resume() can't be removed until D30599.

I'm wondering if I should merge D30599 into D30598. D30598 is simply a precursor to implementing D30599.

Another signed/unsigned update, sorry.

Another small update for the sign auditing.

sys/x86/xen/xen_intr.c
744–745

Based on what I saw in D32866, I suspect there should be a intr_event_bind() here.

Updating to ensure consistency with what I've got. Should still apply, but updates on D30743 have made application unclean.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2023, 7:55 AM
This revision was automatically updated to reflect the committed changes.