Page MenuHomeFreeBSD

xen/intr: mark several pieces unsigned
Needs ReviewPublic

Authored by ehem_freebsd_m5p.com on Nov 1 2021, 8:20 PM.

Details

Reviewers
royger
mhorne
Summary

Fix a fair number of signed/unsigned mismatches. Since these should
always be positive, unsigned is the way to go. While such mismatches
are rampant in the FreeBSD kernel, try to reduce the number in the Xen
code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 42563
Build 39451: arc lint + arc unit

Event Timeline

Trying to reduce the number is a pretty gargantuan task right now. Getting rid of signed/unsigned issues also effects D30598, D30599, D30936, and D30997. I haven't fully narrowed it down, but I suspect CPU_FOREACH() needs the variable to be signed and unsigned at the same time (compares with mp_maxid which is unsigned, but CPU_ABSENT() assumes a signed argument).

Trying to clean these out and two more show up.

I dislike this change, because truly it fixes nothing. It is just churn to appease a sense of code correctness, and code churn is not free.

Finish full checking. The prototype for ffs*() seems *really* bad, it needs to match POSIX, but that is still impressively bad.