Page MenuHomeFreeBSD

xen/control: print warning on call of xctrl_suspend()

Authored by on Apr 6 2021, 1:08 AM.
Referenced Files
F68555382: D29599.diff
Sat, Sep 30, 7:04 PM
Unknown Object (File)
Fri, Sep 29, 3:43 PM
Unknown Object (File)
Tue, Sep 12, 5:49 PM
Unknown Object (File)
Wed, Sep 6, 7:11 AM
Unknown Object (File)
Aug 15 2023, 9:11 PM
Unknown Object (File)
Aug 14 2023, 7:32 AM
Unknown Object (File)
Aug 14 2023, 5:54 AM
Unknown Object (File)
Jun 24 2023, 5:41 AM



Presently suspend/resume and migration aren't supported on Xen/ARM. As
such this shouldn't ever occur.

Modified to check for ARM instead of !x86, since ARM is where support is
missing. Other Xen architectures might get suspend support sooner.

Submitted by: Elliott Mitchell <>
Original implementation: Julien Grall <>, 2014-01-13 17:41:15

Diff Detail

rS FreeBSD src repository - subversion
Lint Passed
No Test Coverage
Build Status
Buildable 38824
Build 35713: arc lint + arc unit

Event Timeline

The commit message doesn't seem to match the actual code, it says: "implement suspend as panic for ARM" yet xctrl_suspend for Arm is just a printf, not a panic.

Hopefully arc grabs the updated commit message, though I suspect I'll
need to manually update the message in Phabricator. retitled this revision from xen/control: implement suspend as panic for ARM to xen/control: print warning on call of xctrl_suspend().Apr 21 2021, 1:42 AM edited the summary of this revision. (Show Details)

Hopefully the updated commit message is okay. That one was the original line, I hadn't been paying too close attention since issues hadn't focused here.

Switching back to checking for amd64 or i386. Likely
suspend/resume/migration won't immediately be supported for RISC-V.

Add machine/intr_machdep.h to guarded headers, this shouldn't be
#included in an architecture-independent file.

This revision is now accepted and ready to land.Apr 24 2021, 8:13 PM