xen/control: print warning on call of xctrl_suspend()
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Apr 6 2021, 1:08 AM.

Details

Reviewers

royger
mhorne

Commits

rG46c46edd1889: xen/control: print warning on call of xctrl_suspend()

Summary

Presently suspend/resume and migration aren't supported on Xen/ARM. As
such this shouldn't ever occur.

Modified to check for ARM instead of !x86, since ARM is where support is
missing. Other Xen architectures might get suspend support sooner.

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2014-01-13 17:41:15

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38742
Build 35631: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Apr 6 2021, 1:08 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2021, 1:08 AM

ehem_freebsd_m5p.com requested review of this revision.Apr 6 2021, 1:08 AM

Harbormaster completed remote builds in B38348: Diff 86878.Apr 6 2021, 1:08 AM

The commit message doesn't seem to match the actual code, it says: "implement suspend as panic for ARM" yet xctrl_suspend for Arm is just a printf, not a panic.

Hopefully arc grabs the updated commit message, though I suspect I'll
need to manually update the message in Phabricator.

Harbormaster completed remote builds in B38742: Diff 87845.Apr 21 2021, 1:41 AM

Hopefully the updated commit message is okay. That one was the original line, I hadn't been paying too close attention since issues hadn't focused here.

Switching back to checking for amd64 or i386. Likely
suspend/resume/migration won't immediately be supported for RISC-V.

Add machine/intr_machdep.h to guarded headers, this shouldn't be
#included in an architecture-independent file.

Harbormaster completed remote builds in B38824: Diff 88024.Apr 23 2021, 5:42 AM

ehem_freebsd_m5p.com mentioned this in D29306: xen/control: disable 15226522304868a8312a84f8ff549fdc6bbf54db on !x86.Apr 23 2021, 10:41 PM

mhorne accepted this revision.Apr 24 2021, 8:13 PM

This revision is now accepted and ready to land.Apr 24 2021, 8:13 PM

ehem_freebsd_m5p.com mentioned this in D29959: xen/devices: purge uses of intr_machdep.h.Apr 25 2021, 1:07 AM

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

Closed by commit rG46c46edd1889: xen/control: print warning on call of xctrl_suspend() (authored by julien_xen.org, committed by royger). · Explain WhyJul 28 2021, 3:30 PM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG46c46edd1889: xen/control: print warning on call of xctrl_suspend().