xen/intr: use func instead of function names
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Mar 30 2021, 6:53 PM.

Details

Reviewers

julien_xen.org
royger
mhorne

Commits

rG9976c5a540c1: xen/intr: use __func__ instead of function names

Summary

Functions tend to get renamed and unless the developer is careful often
debugging messages are missed. As such using func is far superior.
Replace several instances of hard-coded function names.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38186
Build 35075: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Mar 30 2021, 6:53 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 30 2021, 6:53 PM

ehem_freebsd_m5p.com requested review of this revision.Mar 30 2021, 6:53 PM

Harbormaster completed remote builds in B38186: Diff 86566.Mar 30 2021, 6:54 PM

Simply some cleanup. While working with this file I observed several functions hard-coding their names into messages.

If you are going to make changes to these KASSERTS, I feel it would be better if they had a consistent format of: __func__: message

sys/x86/xen/xen_intr.c
1592	FreeBSD's `style(9)` prefers `error != 0`. Dropping the braces is fine.

I don't have a strong opinion on the rewording of the assert messages. @mhorne would you be OK if I commit this with the fixed error != 0 check?

This revision is now accepted and ready to land.Apr 6 2021, 2:49 PM

In D29499#663756, @royger wrote:

I don't have a strong opinion on the rewording of the assert messages. @mhorne would you be OK if I commit this with the fixed error != 0 check?

Sure, that's fine with me.

ehem_freebsd_m5p.com added a parent revision: D29041: xen/timer: make xen timer optional.May 13 2021, 11:03 PM

ehem_freebsd_m5p.com added a child revision: D29602: xen/grant-table: remove explicit linear mapping additions.

ehem_freebsd_m5p.com removed a child revision: D29602: xen/grant-table: remove explicit linear mapping additions.Jul 3 2021, 1:29 AM

Closed by commit rG9976c5a540c1: xen/intr: use __func__ instead of function names (authored by ehem_freebsd_m5p.com, committed by royger). · Explain WhyJul 28 2021, 3:29 PM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG9976c5a540c1: xen/intr: use __func__ instead of function names.