Page MenuHomeFreeBSD

powerpc mpc85xx: Use bus_generic_rman_*
ClosedPublic

Authored by jhb on Jan 12 2024, 10:32 PM.
Tags
None
Referenced Files
F174472860: D43434.id133180.diff
Sat, Oct 3, 12:51 PM
F174470053: D43434.id132713.diff
Sat, Oct 3, 12:23 PM
Unknown Object (File)
Fri, Oct 2, 3:15 PM
Unknown Object (File)
Sat, Sep 26, 8:59 PM
Unknown Object (File)
Fri, Sep 25, 4:42 AM
Unknown Object (File)
Thu, Sep 24, 8:32 AM
Unknown Object (File)
Thu, Sep 24, 4:45 AM
Unknown Object (File)
Mon, Sep 21, 9:03 AM
Subscribers

Details

Summary
  • Consistently map SYS_RES_IOPORT to SYS_RES_MEMORY for bus_activate/deactivate/adjust/release_resource.
  • Implement bus_map/unmap_resource.
  • Add an implementation of bus_adjust_resource.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jan 12 2024, 10:32 PM

I like the approach of the RF_LITTLEENDIAN, but fsl_sata hangs off simple-bus, not the lbc, so it's stuck with manually setting the bus tag. I can test the lbc changes later.

This revision now requires changes to proceed.Jan 19 2024, 2:39 AM

I like the approach of the RF_LITTLEENDIAN, but fsl_sata hangs off simple-bus, not the lbc, so it's stuck with manually setting the bus tag. I can test the lbc changes later.

Hmm, so if it is off of simplebus, does this mean it that the powerpc nexus devices need to honor the flag?

I like the concept of RF_LITTLEENDIAN, but will leave this one alone and let you and Justin hash it out.

I've moved RF_LITTLEENDIAN to a separate change (D43553).

jhibbits added inline comments.
sys/powerpc/mpc85xx/lbc.c
726

Heh, very wrong, and wrong since the beginning. Should be *rid = di->di_bank, from the look of it.

This revision is now accepted and ready to land.Jan 23 2024, 4:56 PM
sys/powerpc/mpc85xx/lbc.c
726

Yes, that's my guess too, but wasn't sure.

This revision was automatically updated to reflect the committed changes.