powerpc: add cryptodev to GENERIC
Needs ReviewPublic
Actions

Authored by pkubaj on May 30 2023, 4:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 8:15 PM

	Unknown Object (File)
	Feb 14 2024, 5:23 AM

	Unknown Object (File)
	Jan 23 2024, 7:18 AM

	Unknown Object (File)
	Jan 4 2024, 5:32 PM

	Unknown Object (File)
	Jan 1 2024, 4:22 AM

	Unknown Object (File)
	Dec 31 2023, 4:18 PM

	Unknown Object (File)
	Dec 31 2023, 4:18 PM

	Unknown Object (File)
	Nov 28 2023, 7:40 PM

View All 31 Files

Subscribers

imp

jhibbits

Details

Reviewers

None

Group Reviewers

PowerPC

Summary

MPC85XX, MPC85XXSPE and QORIQ64 already have cryptodev.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51782
Build 48673: arc lint + arc unit

Event Timeline

pkubaj created this revision.May 30 2023, 4:53 PM

Herald added subscribers: jhibbits, imp. · View Herald TranscriptMay 30 2023, 4:53 PM

pkubaj requested review of this revision.May 30 2023, 4:53 PM

Harbormaster completed remote builds in B51782: Diff 122622.May 30 2023, 4:53 PM

I don't disagree with the change, but I'm not sure it's needed. We could simply remove cryptodev from the Book-E kernels; I think it was added for the sec device in MPC85XX (MPC85XXSPE and QORIQ64 are copied from that), but I don't even know how complete the sec driver really is, and it's definitely *not* supported on QORIQ64 (DPAA-based SEC driver is missing, and I have no hardware with it to develop).

All that said, the only other arch that has cryptodev in the GENERIC config is arm. amd64, i386, and arm64 all don't include it.