Page MenuHomeFreeBSD
Differential D43323

powerpc/SYS.h: implement _SYSCALL_BODY() macro
ClosedPublic
Actions

Authored by brooks on Jan 4 2024, 11:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:02 PM
Unknown Object (File)
Mon, Apr 8, 10:29 PM
Unknown Object (File)
Mar 25 2024, 10:35 PM
Unknown Object (File)
Mar 5 2024, 5:38 AM
Unknown Object (File)
Mar 2 2024, 8:10 AM
Unknown Object (File)
Jan 11 2024, 11:34 PM
Unknown Object (File)
Jan 11 2024, 11:31 PM
Unknown Object (File)
Jan 11 2024, 12:11 PM
Subscribers
imp

Details

Reviewers
jhibbits
pkubaj
Group Reviewers
PowerPC
Commits
rG6597ea4481bb: powerpc/SYS.h: implement _SYSCALL_BODY() macro
Summary

Add _SYSCALL_BODY() macro which invokes the syscall via _SYCALL() and
calls cerror as required. Use to implement PSEUDO() and RSYSCALL().

Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Jan 4 2024, 11:38 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 4 2024, 11:38 PM
brooks requested review of this revision.Jan 4 2024, 11:38 PM
Harbormaster completed remote builds in B55251: Diff 132294.Jan 4 2024, 11:38 PM
brooks added inline comments.Jan 4 2024, 11:42 PM
lib/libc/powerpc/SYS.h
44

D43056 was missing the semicolon on this line. The compiler assertion this triggered is clearly a bug, but I wasn't able to tidy up a reproducer. (For maximum confusion, the clang reproducer doesn't reproduce the bug and instead seems to try to parse the .S file as assembly without preprocessing which goes as well as you'd expect for source that has processed includes, but not expanded macros...)

brooks mentioned this in D43322: powerpc64/SYS.h: implement _SYSCALL_BODY() macro.Jan 4 2024, 11:43 PM
jhibbits accepted this revision.Jan 6 2024, 7:28 PM
This revision is now accepted and ready to land.Jan 6 2024, 7:28 PM
Closed by commit rG6597ea4481bb: powerpc/SYS.h: implement _SYSCALL_BODY() macro (authored by brooks). · Explain WhyJan 11 2024, 6:27 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG6597ea4481bb: powerpc/SYS.h: implement _SYSCALL_BODY() macro.

Revision Contents
Changeset List

PathSize
lib/
libc/
powerpc/
13 lines

Diff 132634

View Options

lib/libc/powerpc/SYS.h

Loading...