Page MenuHomeFreeBSD
Differential D43359

arm: Clean up socdev_va
ClosedPublic
Actions

Authored by andrew on Jan 8 2024, 5:25 PM.
Tags
None
Referenced Files
F156850447: D43359.id134244.diff
Sat, May 16, 9:50 PM
F156850441: D43359.id134244.diff
Sat, May 16, 9:50 PM
Unknown Object (File)
Sat, May 16, 8:37 AM
Unknown Object (File)
Fri, May 15, 4:40 AM
Unknown Object (File)
Thu, May 14, 4:20 AM
Unknown Object (File)
Wed, May 13, 1:38 AM
Unknown Object (File)
Wed, May 13, 1:22 AM
Unknown Object (File)
Thu, May 7, 1:15 PM
View All Files
Subscribers
emaste

Details

Reviewers
imp
manu
Group Reviewers
ARM
arm64
Commits
rG639a626b4050: arm: Clean up socdev_va
Summary

Support socdev_va on arm and ensure the variable is available on arm64.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Jan 8 2024, 5:25 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 8 2024, 5:25 PM
Herald added a subscriber: emaste. · View Herald Transcript
andrew requested review of this revision.Jan 8 2024, 5:25 PM
Harbormaster completed remote builds in B55290: Diff 132435.Jan 8 2024, 5:25 PM
andrew added a child revision: D43360: sys: Simplify enabling EARLY_PRINTF uarts.Jan 8 2024, 5:26 PM
imp accepted this revision.Jan 8 2024, 6:07 PM
imp added inline comments.
sys/arm/include/machdep.h
58

Any reason not to tag this with __read_mostly?

This revision is now accepted and ready to land.Jan 8 2024, 6:07 PM
andrew added inline comments.Jan 9 2024, 11:17 AM
sys/arm/include/machdep.h
58

It doesn't appear to be needed.

andrew mentioned this in D43495: arm64: Add socdev_va symbol when SOCDEV_PA is defined.Jan 18 2024, 5:25 PM
Closed by commit rG639a626b4050: arm: Clean up socdev_va (authored by andrew). · Explain WhyFeb 13 2024, 11:53 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG639a626b4050: arm: Clean up socdev_va.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
8 lines
include/
7 lines
arm64/
arm64/
9 lines

Diff 134244

View Options

sys/arm/arm/machdep.c

Loading...
View Options

sys/arm/include/machdep.h

Loading...
View Options

sys/arm64/arm64/machdep.c

Loading...