libthr: avoid varargs in fcntl and openat interposers
ClosedPublic
Actions

Authored by brooks on Wed, May 8, 1:42 PM.

Details

Reviewers

jhibbits
kib
jrtc27
imp

Commits

rGec2b6b16aac4: libthr: avoid varargs in fcntl and openat interposers

Summary

Align these signatures with the ones in syscalls.master (and thus
libsys.h). There's no reason to do va_args twice and in some ABIs
(e.g,, CheriABI) you can't access fixed arguments as varargs if you
weren't called with varargs signature.

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Wed, May 8, 1:42 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, May 8, 1:42 PM

brooks requested review of this revision.Wed, May 8, 1:42 PM

Harbormaster completed remote builds in B57617: Diff 138248.Wed, May 8, 1:42 PM

kib accepted this revision.Wed, May 8, 2:13 PM

This revision is now accepted and ready to land.Wed, May 8, 2:13 PM

LGTM, though I didn't compile it.

imp accepted this revision.Wed, May 8, 2:28 PM

Closed by commit rGec2b6b16aac4: libthr: avoid varargs in fcntl and openat interposers (authored by brooks). · Explain WhyWed, May 8, 2:50 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGec2b6b16aac4: libthr: avoid varargs in fcntl and openat interposers.

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_private.h

4 lines

thr_syscalls.c

25 lines

Diff 138251

View Options

lib/libthr/thread/thr_private.h