Page MenuHomeFreeBSD

kern/intr: start adding non-NULL event interface variant
Needs ReviewPublic

Authored by ehem_freebsd_m5p.com on Jun 13 2025, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 1:16 AM
Unknown Object (File)
Sat, Sep 13, 3:01 AM
Unknown Object (File)
Sep 8 2025, 4:32 PM
Unknown Object (File)
Sep 6 2025, 12:20 PM
Unknown Object (File)
Sep 4 2025, 2:23 PM
Unknown Object (File)
Aug 31 2025, 1:42 PM
Unknown Object (File)
Aug 31 2025, 12:23 AM
Unknown Object (File)
Aug 21 2025, 8:08 PM
Subscribers

Details

Reviewers
mhorne
jhb
Summary

Nearly all callers have are known to have already initialize the event
before calling these functions. As such add variants which assume the
event will be non-NULL and will panic() if this occurs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67653
Build 64536: arc lint + arc unit

Event Timeline

@mhorne this is a follow-on to D33479. If the normal interface is going to include NULL-checks, but they can be omitted in some fairly common circumstances what do you prefer for new names? Underscore prefix tends to point to internal (though can also indicate lower-level), but some letter suffix would also work. Your view since you've been emphasizing the consistency here?

Trivial update. Wondering which functions to include this flag for initially. Destroy is helpful as it provides an alternative elsewhere.