runqueue.9: rewrite
AcceptedPublic
Actions

Authored by mchoo on Fri, Sep 25, 6:15 PM.

Details

Reviewers

Group Reviewers

manpages
scheduler

Summary

The old run queue documentation is outdated: the interface was
refactored into sys/runq.h with a completely different design. Rewrite
the page for the current structures, macros, and functions, retain
choosethread(9), and refresh the aliases.

MFC after: 2 weeks
Sponsored by: FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 77338
Build 74221: arc lint + arc unit

Event Timeline

mchoo created this revision.Fri, Sep 25, 6:15 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Sep 25, 6:15 PM

Harbormaster completed remote builds in B77338: Diff 187699.Fri, Sep 25, 6:15 PM

mchoo requested review of this revision.Fri, Sep 25, 6:15 PM

OK from manpages.

This revision is now accepted and ready to land.Sat, Sep 26, 7:32 PM

For this level of modification, I guess it's ok to add a copyright holder?

ping @jhb and @olce (scheduler) for mentor approval

jhb added inline comments.Mon, Sep 28, 6:09 PM

share/man/man9/Makefile
1979	You will need ObsoleteFiles.inc entries for the removed symlinks.
share/man/man9/runqueue.9
1	You can replace the copyright if you wish as you've basically rewritten the entire page at this point. The only remaining common lines are formatting things like .Dt for which there is only one way to express the content.
sys/sys/runq.h
48	I'm not sure these comments are effective in practice btw. I would probably not include it.