On RCTL, guard the call to rctl_proc_ucred_changed() with cred_set instead of relying on error being 0 as this is more error-prone on potential future changes to setcred().

• Ensure the last block is executed only on no error.

Wow, sorry, I forgot to wrap the last block (doing rctl_proc_ucred_changed()) inside a if (error != 0).

Ping?

(With same remark as Alan.)

For the changes in unionfs_lock(), there is indeed a window after the interlock drop and before lock acquire and drop where the "root" reference unionfs holds (through unionfs_node; the one that allows to call vholdnz() above) could be dropped (it's the same window described in the big comment about checking the proper target vnode (lower or upper) was locked).

This change is an improvement without drawbacks, so should be committed.

We have indeed several problems with VOP_OPEN()/VOP_CLOSE(), e.g., they are not always called in pairs, and even if they are the passed td may not match between an open and close. These interfaces need serious revision, in particular determining which exact info the filesystems would like to use and if there are better ways to obtain them.

Please don't forget to exclude the changes in sys/netinet/ip_carp.c as they are completely unrelated.

In D52960#1212126, @rmacklem wrote:

Looks ok to me. I'll leave min vs MIN up to you.

Seems good (disclaimer: I only did manual code analysis, but didn't test).

Update after discussion and fixing the last use of vm_domainset_iter_page_init() with an object not write-locked in D52982.

Indeed, that is the only problem in UMA.

Please add Reported by: olce at commit, thanks!

It seems good indeed that not all man pages related to libraries go into separate packages, as some are targeted at administrators.

Superseded by the series starting at D52960 (through D52964).