pf: remove unused variable allrulelist

[kp]

Summary

We update this, and assert on it, but never actually iterate the list or use it
to look anything up.

Sponsored by: Rubicon Communications, LLC ("Netgate")

[glebius]

In pf_krule we got remaining:

#ifdef PF_WANT_32_TO_64_COUNTER
        LIST_ENTRY(pf_krule)     allrulelist;
        bool                     allrulelinked;
#endif

This gives a hint when was it used. Shouldn't this be removed from krule as well?

[mjg]

This *is* used by pf_rule_counter_u64_periodic. The goal is to sum up the 32 bit values frequently enough(tm) that they don't overflow.

[glebius]

In D53070#1212661, @mjg wrote:

This *is* used by pf_rule_counter_u64_periodic. The goal is to sum up the 32 bit values frequently enough(tm) that they don't overflow.

Then probably better to rename the field from allrulelist to markerlist.

[kp]

Thanks for catching that. I'm not sure how I missed it, but I'm glad I remembered you wrote it and would be a good person to copy on a review.

I do still want to murder this code, but we'll wait until armv7 finally dies, or dies enough.

[mjg]

In D53070#1212811, @glebius wrote:

In D53070#1212661, @mjg wrote:

This *is* used by pf_rule_counter_u64_periodic. The goal is to sum up the 32 bit values frequently enough(tm) that they don't overflow.

Then probably better to rename the field from allrulelist to markerlist.

but this is a list of all rules

In D53070#1212847, @kp wrote:

I do still want to murder this code, but we'll wait until armv7 finally dies, or dies enough.

one can consider reverting this to a state prior to introduction of per-cpu counters. that is, just have a var updated directly. this loses updates, but maybe it's good enough for armv7?

[kp]

In D53070#1213136, @mjg wrote:

In D53070#1212847, @kp wrote:

I do still want to murder this code, but we'll wait until armv7 finally dies, or dies enough.

one can consider reverting this to a state prior to introduction of per-cpu counters. that is, just have a var updated directly. this loses updates, but maybe it's good enough for armv7?

We don't need to do anything about it right now.
We're going to stop releasing updates for the 3100 any decade now, and then we can think about how much we still care about armv7.