Page MenuHomeFreeBSD

pf: Free pf_rule_items when state is not created
ClosedPublic

Authored by vegeta_tuxpowered.net on Oct 12 2023, 4:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 20, 12:02 PM
Unknown Object (File)
Tue, May 19, 5:31 AM
Unknown Object (File)
Tue, May 19, 12:47 AM
Unknown Object (File)
Mon, May 18, 6:21 AM
Unknown Object (File)
Sun, May 17, 12:48 AM
Unknown Object (File)
Wed, May 13, 10:49 PM
Unknown Object (File)
Wed, May 13, 10:49 PM
Unknown Object (File)
Wed, May 13, 10:49 PM

Details

Summary

This addresses the issues of pf_rule_times leaking in case of stateless rules and in case of state creation failures, like hitting the state limit.

Sponsored by: InnoGames GmbH

Test Plan

I've created a rulesets with a match rule and with a pass rule with state limit or with no state. After sending a few packets through I've unloaded pf.ko and that resulted with memory leak being logged. With this patch the leak is not logged anymore.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable