Page MenuHomeFreeBSD

pf: Fix duplicate storage of direction
ClosedPublic

Authored by vegeta_tuxpowered.net on Jul 12 2023, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 27, 8:30 PM
Unknown Object (File)
Thu, Jun 26, 9:14 AM
Unknown Object (File)
Wed, Jun 25, 11:53 AM
Unknown Object (File)
Tue, Jun 24, 12:25 AM
Unknown Object (File)
May 13 2025, 5:48 PM
Unknown Object (File)
Feb 25 2025, 11:31 PM
Unknown Object (File)
Feb 1 2025, 5:24 AM
Unknown Object (File)
Jan 30 2025, 5:15 AM

Details

Summary

The variable storing the direction of a processed packet is passed around to many functions. Most of those functions already have a pointer to struct pf_pdesc which also contains the direction. By using the one in struct pf_pdesc we can reduce the amount of arguments passed around.

Sponsored by: InnGames GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net edited the summary of this revision. (Show Details)

Looks sensible at first glance. I'm test-building and running the tests just in case, but I expect you've done that already.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2023, 6:07 PM
This revision was automatically updated to reflect the committed changes.