Differential D41008

pf: Fix duplicate storage of direction
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Jul 12 2023, 4:34 PM.

Tags

None

Referenced Files

	F170628757: D41008.diff
	Sat, Sep 5, 5:24 PM

	Unknown Object (File)
	Sat, Sep 5, 6:10 AM

	Unknown Object (File)
	Sat, Sep 5, 2:46 AM

	Unknown Object (File)
	Thu, Sep 3, 5:18 AM

	Unknown Object (File)
	Thu, Sep 3, 12:38 AM

	Unknown Object (File)
	Wed, Sep 2, 5:00 PM

	Unknown Object (File)
	Tue, Sep 1, 1:43 PM

	Unknown Object (File)
	Tue, Sep 1, 12:45 AM

Subscribers

Details

Reviewers

Commits

rGf2064dd1f170: pf: Fix duplicate storage of direction

Summary

The variable storing the direction of a processed packet is passed around to many functions. Most of those functions already have a pointer to struct pf_pdesc which also contains the direction. By using the one in struct pf_pdesc we can reduce the amount of arguments passed around.

Sponsored by: InnGames GmbH

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.Jul 12 2023, 4:34 PM

Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald TranscriptJul 12 2023, 4:34 PM

vegeta_tuxpowered.net requested review of this revision.Jul 12 2023, 4:34 PM

vegeta_tuxpowered.net edited the summary of this revision. (Show Details)

Looks sensible at first glance. I'm test-building and running the tests just in case, but I expect you've done that already.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2023, 6:07 PM

Closed by commit rGf2064dd1f170: pf: Fix duplicate storage of direction (authored by vegeta_tuxpowered.net, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf2064dd1f170: pf: Fix duplicate storage of direction.

Revision Contents
Changeset List

Path

Size

sys/

net/

4 lines

14 lines

netpfil/

pf/

8 lines

287 lines

22 lines

38 lines

Diff 124580

sys/net/if_pflog.h

Loading...

sys/net/pfvar.h

Loading...

sys/netpfil/pf/if_pflog.c

Loading...

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_lb.c

Loading...

sys/netpfil/pf/pf_norm.c

Loading...