Page MenuHomeFreeBSD
Differential D42363

pf tests: Fix missing pf enabling
AbandonedPublic
Actions

Authored by kp on Oct 25 2023, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 10 2024, 9:57 PM
Unknown Object (File)
Dec 9 2024, 2:03 AM
Unknown Object (File)
Nov 11 2024, 10:17 AM
Unknown Object (File)
Nov 7 2024, 12:58 PM
Unknown Object (File)
Nov 7 2024, 10:40 AM
Unknown Object (File)
Sep 9 2024, 9:00 AM
Unknown Object (File)
Sep 8 2024, 10:26 PM
Unknown Object (File)
Sep 8 2024, 3:43 AM
View All 27 Files
Subscribers
farrokhi
glebius
imp
melifaro

Details

Reviewers
vegeta_tuxpowered.net

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Oct 25 2023, 5:41 PM
Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptOct 25 2023, 5:41 PM
vegeta_tuxpowered.net requested review of this revision.Oct 25 2023, 5:41 PM
vegeta_tuxpowered.net mentioned this in D42355: pf: Fix packet reassembly.Oct 25 2023, 5:48 PM
kp added a comment.Oct 26 2023, 12:25 PM

The bug is in D42355, where we remove part of this test case, including the pfctl -e.
This fixes it, but I'm going to squash this together with the other review to keep the history simpler.

vegeta_tuxpowered.net added a comment.Oct 26 2023, 1:05 PM
In D42363#966766, @kp wrote:

The bug is in D42355, where we remove part of this test case, including the pfctl -e.
This fixes it, but I'm going to squash this together with the other review to keep the history simpler.

Good catch! I thought it's something totally separate, my bad.

kp commandeered this revision.Oct 29 2023, 9:11 AM
kp edited reviewers, added: vegeta_tuxpowered.net; removed: kp.

Commandeering to abandon. We included this in D42355.

kp abandoned this revision.Oct 29 2023, 9:12 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
pf/
1 line

Diff 129385

View Options

tests/sys/netpfil/pf/fragmentation_compat.sh

Loading...