ure: Initialize ifm_active in ure_ifmedia_sts
ClosedPublic
Actions

Authored by emaste on Tue, Nov 3, 3:46 PM.

Project Tags

None

Referenced Files

	F177546486: D61158.1794679908.diff
	Fri, Nov 13, 6:11 PM

	F177545285: D61158.1794677914.diff
	Fri, Nov 13, 5:38 PM

	F177544665: D61158.1794676771.diff
	Fri, Nov 13, 5:19 PM

	F177544550: D61158.1794676409.diff
	Fri, Nov 13, 5:13 PM

Subscribers

imp

Details

Reviewers

kbowling
pouria

Commits

rG83067a22396f: ure: Initialize ifm_active in ure_ifmedia_sts

Summary

Most ure(4) devices use mii; 8156 and 8156B do not and have special
cases throughout the driver.

ifmedia_ioctl() sets ifmr->ifm_active to ifm_cur->ifm_media before
calling the status callback.  The 8156 case in ure_ifmedia_sts ORs in
the subtype and duplex flags to the existing value, which may result in
garbage values.

Instead, start by setting ifm_active to just IFM_ETHER before ORing in
other bits.

Fixes: d4cf41a99b40 ("Add support for RTL8153B, RTL8156 and RTL8156B to if_ure(4).")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Tue, Nov 3, 3:46 PM

emaste created this revision.

kbowling accepted this revision.Tue, Nov 3, 7:11 PM

kbowling added inline comments.

sys/dev/usb/net/if_ure.c
1459	Not sure if there is some natural final else case for these conditionals, IFM_NONE?

This revision is now accepted and ready to land.Tue, Nov 3, 7:11 PM

emaste added inline comments.Tue, Nov 3, 7:15 PM

sys/dev/usb/net/if_ure.c
1459	Possibly, but we'd have `IFM_FDX \| IFM_NONE` or `IFM_HDX \| IFM_NONE` which doesn't make sense. The hw/driver will not actually reach this case so I'm inclined to just leave it. Or we could explicitly set `ifmr->ifm_active = IFM_ETHER \| IFM_NONE` for this case?