Page MenuHomeFreeBSD

netinet6: use memcpy/memset/memcmp for consistency
AcceptedPublic

Authored by vinicius_ferrao.net.br on Sat, Jul 11, 10:11 PM.
Tags
None
Referenced Files
F162686380: D58177.diff
Wed, Jul 15, 6:32 PM
F162630065: D58177.id.diff
Wed, Jul 15, 6:39 AM
Unknown Object (File)
Tue, Jul 14, 6:28 PM
Unknown Object (File)
Tue, Jul 14, 1:25 AM

Details

Reviewers
pouria
adrian
glebius
Group Reviewers
network
Summary

Convert the remaining bzero()/bcopy()/bcmp() calls in the neighbor
discovery handlers to memset()/memcpy()/memcmp(), and drop the now
redundant caddr_t casts.

This cleanup is to keep code consistent with:
https://cgit.freebsd.org/src/commit/?id=bac4760524a2a15ce75e35251f0c9cdf31732f3f

Code path that isn't affected by the commit is left untouched.

No functional change intended.

Sponsored by: VersatusHPC

Test Plan

Rebuild of GENERIC with -Werror

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Thanks! Note that when doing such cleanups it is important to pay attention to the fact that bcopy(9) allows overlapping memory regions and memcpy(9) does not. In this particular patch everything looks fine.

This revision is now accepted and ready to land.Sun, Jul 12, 3:49 AM