install: add -z <max_cmp_size> option
ClosedPublic
Actions

Authored by ray on Mon, May 25, 7:57 AM.

Details

Reviewers

glebius
imp
ziaee

Commits

rG97cad013a50a: install: add -z <max_cmp_size> option

Summary

Introduces the -z <max_cmp_size> flag, enabling users to set a custom file size limit for pre-installation change checks and avoiding future hard-coded limit modifications.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ray created this revision.Mon, May 25, 7:57 AM

Herald added a subscriber: ziaee. · View Herald TranscriptMon, May 25, 7:57 AM

ray requested review of this revision.Mon, May 25, 7:57 AM

Harbormaster completed remote builds in B73415: Diff 178540.Mon, May 25, 7:57 AM

Update usage.

Harbormaster completed remote builds in B73417: Diff 178542.Mon, May 25, 9:02 AM

I'd suggest to split the default increase and the added new option into two separate commits.

The commit that increases the default should have some data to back the decision made. E.g. installworld time decreased by that many seconds.

glebius added a reviewer: ziaee.Mon, May 25, 6:26 PM

glebius added inline comments.

usr.bin/xinstall/install.1
269–274	I think wording can be improved here. Subscribing an expert.

Move the hard-coded limit to separate commit.

Harbormaster completed remote builds in B73470: Diff 178692.Wed, May 27, 9:03 AM

ray retitled this revision from install: Increase max comparison size to 64MB; add -z option to install: add -z <max_cmp_size> option.Wed, May 27, 9:09 AM

ray edited the summary of this revision. (Show Details)

In D57230#1311556, @glebius wrote:

I'd suggest to split the default increase and the added new option into two separate commits.

The commit that increases the default should have some data to back the decision made. E.g. installworld time decreased by that many seconds.

"installworld time" can't be resquied due to the build of the llvm and its libs :D
But IMO, -C is not for the time reduction (at least it is less important), rather to keep unchanged parts w/o overwriting. Reduce flash writes, keep changes visible, etc.

glebius accepted this revision.Wed, May 27, 5:45 PM

This revision is now accepted and ready to land.Wed, May 27, 5:45 PM

Closed by commit rG97cad013a50a: install: add -z <max_cmp_size> option (authored by ray). · Explain WhyWed, May 27, 10:59 PM

This revision was automatically updated to reflect the committed changes.

ray added a commit: rG97cad013a50a: install: add -z <max_cmp_size> option.

-C for builds makes a lot of sense.
I think we should remove the limit all together. It was added in originally because mmap was being used in commit de264c2bd89b931303db40fb8a50c9ee5ed8f858.