kgss: remove KGSS_VNET_* macros family

[glebius]

Summary

The original idea was that something else than VNET(9) might be used for
kgss in jails, but that is very unlikely to happen.

Mechanical change done with sed+grep. No functional change.

[rmacklem]

I'm fine with getting rid of the macros.

I assume you plan on committing this first,
since all the kgss_gssd_handle case get de-vnet'd
by the other commits?

sys/kgssapi/gss_delete_sec_context.c

60

I think this test can just go away now?
And kgss_gssd_handle is no longer vnet'd
with the other patch, so why not just zap it?

[rmacklem]

You might want to ask bz@ before getting rid of the
macros, since my recollection was that they were his
idea when I did the code?

[glebius]

Bjoern, can you please confirm you are fine with the change.

[bz]

Sorry but I don't know this code specifically and what these macros are doing or not in the end; unless I am going to read it all to understand I cannot help given there is no high level description of what you are trying to (de-)virtualize here.

I had initially asked if it was possible to run NFS exports from within jails. Rick made that happen in 2003(?). And that's kind-of as much as I know. I believe I had not reviewed any of that code back then; you may want to talk to people who did -- I think @markj , @jamie and @mjg did in the end when it came to jails and mounted and some other bits got refined. But that's just from vague memory.

[bz]

There also was NFSD_VNET_NAME et al intially btw (a quick grep says some still exists from ed03776ca7f43de8275da80cfa89a9ecc4732f82 ).

If you just want to remove the special prefixes I am fine; I believe they came from a transition time during devleopment but @rmacklem would have to know better than me.
I think it'll unlikely happen that we'll ever virtualize nfs without vnet. Maybe that helps?

[rmacklem]

In D56560#1296776, @bz wrote:

Sorry but I don't know this code specifically and what these macros are doing or not in the end; unless I am going to read it all to understand I cannot help given there is no high level description of what you are trying to (de-)virtualize here.

I had initially asked if it was possible to run NFS exports from within jails. Rick made that happen in 2003(?). And that's kind-of as much as I know. I believe I had not reviewed any of that code back then; you may want to talk to people who did -- I think @markj , @jamie and @mjg did in the end when it came to jails and mounted and some other bits got refined. But that's just from vague memory.

Well, my vague memory is that you (bz@) requested that the vnet macros
be hidden behind other macros because you thought you might want
to do something different than that happen.
All the macros like KRPC_CURVNET_SET() do is CURVNET_SET(), etc.

Oh, and it happens a few years ago (closer to 2023 than 2003).

If you (bz@) don't want/need the macros, they can go away.

[bz]

In D56560#1296780, @rmacklem wrote:

In D56560#1296776, @bz wrote:

Sorry but I don't know this code specifically and what these macros are doing or not in the end; unless I am going to read it all to understand I cannot help given there is no high level description of what you are trying to (de-)virtualize here.

I had initially asked if it was possible to run NFS exports from within jails. Rick made that happen in 2003(?). And that's kind-of as much as I know. I believe I had not reviewed any of that code back then; you may want to talk to people who did -- I think @markj , @jamie and @mjg did in the end when it came to jails and mounted and some other bits got refined. But that's just from vague memory.

Well, my vague memory is that you (bz@) requested that the vnet macros
be hidden behind other macros because you thought you might want
to do something different than that happen.
All the macros like KRPC_CURVNET_SET() do is CURVNET_SET(), etc.

Oh, and it happens a few years ago (closer to 2023 than 2003).

If you (bz@) don't want/need the macros, they can go away.

2023 of course or end of 2022; I just went through my outgoing emails to you and I cannot see any reference to any of these macros (could be I missed it in the text, I just screened for upper case parts). I really do not know anymore. I am sorry. If it wasn't jamie or someone else, then please just normalize them to normal VNET macros.