Page MenuHomeFreeBSD
Differential D56561

kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks
ClosedPublic
Actions

Authored by glebius on Apr 21 2026, 5:55 PM.
Tags
None
Referenced Files
F160476289: D56561.id176444.diff
Wed, Jun 24, 10:01 PM
Unknown Object (File)
Wed, Jun 17, 3:10 PM
Unknown Object (File)
Wed, Jun 17, 12:41 PM
Unknown Object (File)
Thu, Jun 11, 8:21 PM
Unknown Object (File)
Thu, Jun 4, 9:50 AM
Unknown Object (File)
Sun, May 31, 8:17 AM
Unknown Object (File)
Sun, May 31, 8:14 AM
Unknown Object (File)
Sun, May 31, 4:47 AM
View All 32 Files
Subscribers
imp

Details

Reviewers
rmacklem
Commits
rGf8c8cc64ff0d: kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks
rG2bd2f267f344: kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks
Summary

These RPC methods correctly acquire the kgss_gssd_handle later with call
to kgss_gssd_client().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Apr 21 2026, 5:55 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2026, 5:55 PM
glebius requested review of this revision.Apr 21 2026, 5:55 PM
Harbormaster completed remote builds in B72423: Diff 176023.Apr 21 2026, 5:55 PM
glebius added a parent revision: D56560: kgss: remove KGSS_VNET_* macros family.Apr 21 2026, 5:55 PM
glebius added a child revision: D56562: kgss: de-virtualize kgss_gssd_handle.
rmacklem accepted this revision.Apr 21 2026, 10:17 PM

Looks ok to me. If kgss_gssd_handle can never
be NULL, removing the checks for non-NULL
might simplify the code a bit?

sys/kgssapi/gss_release_cred.c
57

As I asked in the other review. Does this check
make any sense now? (ie. Can it ever be NULL?)

This revision is now accepted and ready to land.Apr 21 2026, 10:17 PM
Closed by commit rG2bd2f267f344: kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks (authored by glebius). · Explain WhyApr 25 2026, 2:56 AM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG2bd2f267f344: kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks.
glebius added a commit: rGf8c8cc64ff0d: kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks.Apr 27 2026, 4:12 PM

Revision Contents
Changeset List

PathSize
sys/
kgssapi/
8 lines
8 lines
8 lines

Diff 176444

View Options

sys/kgssapi/gss_delete_sec_context.c

Loading...
View Options

sys/kgssapi/gss_release_cred.c

Loading...
View Options

sys/kgssapi/gss_release_name.c

Loading...