Differential D56651

if_awg: Add missing awg_poll() prototype
ClosedPublic
Actions

Authored by ivy on Apr 26 2026, 10:44 PM.

Tags

None

Referenced Files

	F159861842: D56651.diff
	Thu, Jun 18, 9:51 PM

	Unknown Object (File)
	Fri, Jun 5, 9:37 PM

	Unknown Object (File)
	Fri, Jun 5, 5:32 AM

	Unknown Object (File)
	Thu, Jun 4, 6:22 PM

	Unknown Object (File)
	Thu, Jun 4, 1:40 AM

	Unknown Object (File)
	Tue, May 26, 8:07 AM

	Unknown Object (File)
	Tue, May 26, 8:02 AM

	Unknown Object (File)
	Sun, May 24, 5:37 AM

View All 35 Files

Subscribers

Details

Reviewers

thj
andrew
manu
adrian
tuexen
mmel

Group Reviewers

network
ARM

Commits

rGc73cd9ca3ff8: if_awg: Add missing awg_poll() prototype

Summary

The function awg_poll() was missing a prototype, which causes the build
to fail if DEVICE_POLLING is enabled, which it is in the ARMADAXP config.

MFC after: 2 weeks
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Apr 26 2026, 10:44 PM

Herald added a reviewer: andrew. · View Herald TranscriptApr 26 2026, 10:44 PM

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

ivy requested review of this revision.Apr 26 2026, 10:44 PM

Harbormaster completed remote builds in B72559: Diff 176589.Apr 26 2026, 10:44 PM

adrian accepted this revision.Apr 26 2026, 10:55 PM

This revision is now accepted and ready to land.Apr 26 2026, 10:55 PM

I wonder if anybody have actually tested that old mode on this relatively new driver. I wonder if anybody in the world runs with the device polling today at all.

since ARMADAXP is a Marvell SoC and if_awg is an Allwinner IC, it's quite possible this combination has never been used by anyone. but, this does currently break the build, and this fix is simpler than either removing DEVICE_POLLING from ARMADAXP or removing polling support from awg.

tuexen accepted this revision.Apr 27 2026, 5:24 AM

mmel accepted this revision.Apr 27 2026, 5:35 AM

Closed by commit rGc73cd9ca3ff8: if_awg: Add missing awg_poll() prototype (authored by ivy). · Explain WhyApr 27 2026, 6:58 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGc73cd9ca3ff8: if_awg: Add missing awg_poll() prototype.

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

3 lines

Diff 176608

sys/arm/allwinner/if_awg.c

Loading...