Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

glebius committed rS353732: Make rt_getifa_fib() static..
Make rt_getifa_fib() static.
Fri, Oct 18, 3:20 PM

Thu, Oct 17

glebius committed rS353695: Revert two parts of r353292 that enter epoch when processing vlan capabilities..
Revert two parts of r353292 that enter epoch when processing vlan capabilities.
Thu, Oct 17, 8:18 PM
glebius committed rS353687: Quickly fix up r353683: enter the epoch before calling into netisr_dispatch()..
Quickly fix up r353683: enter the epoch before calling into netisr_dispatch().
Thu, Oct 17, 5:03 PM
glebius committed rS353683: igmp_v1v2_queue_report() doesn't require epoch..
igmp_v1v2_queue_report() doesn't require epoch.
Thu, Oct 17, 4:02 PM

Wed, Oct 16

glebius committed rS353654: do_link_state_change() is executed in taskqueue context and in.
do_link_state_change() is executed in taskqueue context and in
Wed, Oct 16, 4:33 PM

Tue, Oct 15

glebius committed rS353598: Missing from r353596..
Missing from r353596.
Tue, Oct 15, 9:32 PM
glebius committed rS353596: When assertion for a thread not being in an epoch fails also print all.
When assertion for a thread not being in an epoch fails also print all
Tue, Oct 15, 9:24 PM
glebius closed D22017: Add NOEPOCHASSERT()..
Tue, Oct 15, 9:24 PM
glebius closed D19111: Summary: widen net_epoch coverage up to all packet processing.
Tue, Oct 15, 4:20 PM
glebius added inline comments to D22017: Add NOEPOCHASSERT()..
Tue, Oct 15, 4:19 PM
glebius updated the diff for D22017: Add NOEPOCHASSERT()..

Re-do the patch a bit. Instead of new macro, just add epoch_trace_list()
to the three critical places where we must not be in an epoch.

Tue, Oct 15, 3:45 PM
glebius committed rS353566: Remove pfctlinput2(). It came from KAME and had never ever been in use..
Remove pfctlinput2(). It came from KAME and had never ever been in use.
Tue, Oct 15, 3:40 PM

Mon, Oct 14

glebius committed rS353522: if_delmulti() is never called without ifp argument, assert this instead.
if_delmulti() is never called without ifp argument, assert this instead
Mon, Oct 14, 9:18 PM
glebius committed rS353520: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:33 PM
glebius committed rS353519: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:32 PM
glebius committed rS353517: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:32 PM
glebius committed rS353516: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:32 PM
glebius committed rS353515: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:32 PM
glebius committed rS353514: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:32 PM
glebius committed rS353513: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:30 PM
glebius committed rS353512: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:30 PM
glebius committed rS353511: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:30 PM
glebius committed rS353510: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:30 PM
glebius committed rS353509: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:29 PM
glebius committed rS353508: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:29 PM
glebius committed rS353507: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:27 PM
glebius committed rS353506: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:27 PM
glebius committed rS353505: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:23 PM
glebius committed rS353504: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:22 PM
glebius committed rS353503: Convert if_foreach_llmaddr() KPI..
Convert if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:21 PM
glebius committed rS353502: Convert to if_foreach_llmaddr() KPI..
Convert to if_foreach_llmaddr() KPI.
Mon, Oct 14, 8:18 PM
glebius committed rS353495: Use epoch(9) directly instead of obsoleted KPI..
Use epoch(9) directly instead of obsoleted KPI.
Mon, Oct 14, 4:38 PM
glebius committed rS353494: ipfw(4) rule matching always happens in network epoch..
ipfw(4) rule matching always happens in network epoch.
Mon, Oct 14, 4:37 PM
glebius committed rS353492: in6ifa_llaonifp() is never called from fast path, so do not require.
in6ifa_llaonifp() is never called from fast path, so do not require
Mon, Oct 14, 3:34 PM
glebius added a reviewer for D22003: Add lle_event handler to ARP: melifaro.
Mon, Oct 14, 2:59 PM
glebius added inline comments to D22017: Add NOEPOCHASSERT()..
Mon, Oct 14, 4:22 AM
glebius created D22017: Add NOEPOCHASSERT()..
Mon, Oct 14, 4:20 AM
glebius committed rS353485: Since EPOCH_TRACE had been moved to opt_global.h, we don't need to waste.
Since EPOCH_TRACE had been moved to opt_global.h, we don't need to waste
Mon, Oct 14, 4:18 AM
glebius committed rS353484: Revert r353313. It is not needed with r353357 and is actually incorrect..
Revert r353313. It is not needed with r353357 and is actually incorrect.
Mon, Oct 14, 4:10 AM

Sun, Oct 13

glebius committed rS353467: vlan_config() isn't always called in epoch context..
vlan_config() isn't always called in epoch context.
Sun, Oct 13, 3:15 PM
glebius committed rS353461: Don't cover in6_ifattach() with network epoch, as it may call into.
Don't cover in6_ifattach() with network epoch, as it may call into
Sun, Oct 13, 4:25 AM

Thu, Oct 10

glebius committed rS353427: Don't use if_maddr_rlock() in 802.11, use epoch(9) directly instead..
Don't use if_maddr_rlock() in 802.11, use epoch(9) directly instead.
Thu, Oct 10, 11:55 PM
glebius committed rS353426: Don't use if_maddr_rlock() in sppp(4), use epoch(9) directly instead..
Don't use if_maddr_rlock() in sppp(4), use epoch(9) directly instead.
Thu, Oct 10, 11:54 PM
glebius committed rS353425: Don't use if_maddr_rlock() in tuntap(4), use epoch(9) directly instead..
Don't use if_maddr_rlock() in tuntap(4), use epoch(9) directly instead.
Thu, Oct 10, 11:51 PM
glebius committed rS353424: Interface output method must be executed in network epoch, so if_addr_rlock().
Interface output method must be executed in network epoch, so if_addr_rlock()
Thu, Oct 10, 11:50 PM
glebius committed rS353423: Don't use if_maddr_rlock() in ng_eiface(4), use epoch(9) directly instead..
Don't use if_maddr_rlock() in ng_eiface(4), use epoch(9) directly instead.
Thu, Oct 10, 11:49 PM
glebius committed rS353422: The divert(4) module must always be running in network epoch, thus.
The divert(4) module must always be running in network epoch, thus
Thu, Oct 10, 11:49 PM
glebius committed rS353421: Don't use if_maddr_rlock() in ng_ether(4), use epoch(9) directly instead..
Don't use if_maddr_rlock() in ng_ether(4), use epoch(9) directly instead.
Thu, Oct 10, 11:47 PM
glebius committed rS353420: Add two extra functions that basically give count of addresses.
Add two extra functions that basically give count of addresses
Thu, Oct 10, 11:45 PM
glebius closed D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Thu, Oct 10, 11:43 PM
glebius committed rS353419: Provide new KPI for network drivers to access lists of interface.
Provide new KPI for network drivers to access lists of interface
Thu, Oct 10, 11:43 PM

Wed, Oct 9

glebius added a comment to D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..

The plan is to commit first series of commits (see my github link), then do drivers in small batches, asking for testing and resorting to committing untested after timeout, if no volunteers found. When all drivers are done, finalize with the last two commits. Looks like we are all positive, so I'm going to proceed.

Wed, Oct 9, 9:59 PM
glebius updated the diff for D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..

Address reviewers comments.

Wed, Oct 9, 9:56 PM
glebius added inline comments to D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Wed, Oct 9, 9:45 PM
glebius committed rS353357: Revert most of the multicast changes from r353292. This needs a more.
Revert most of the multicast changes from r353292. This needs a more
Wed, Oct 9, 5:03 PM
glebius committed rS353356: ip6_output() has a complex set of gotos, and some can jump out of.
ip6_output() has a complex set of gotos, and some can jump out of
Wed, Oct 9, 5:02 PM
glebius committed rS353355: Cleanup unneeded includes that crept in with r353292..
Cleanup unneeded includes that crept in with r353292.
Wed, Oct 9, 5:00 PM
glebius committed rS353350: ifnet_byindex_ref() requires network epoch..
ifnet_byindex_ref() requires network epoch.
Wed, Oct 9, 4:22 PM
glebius committed rS353349: Enter network epoch in domain callouts..
Enter network epoch in domain callouts.
Wed, Oct 9, 4:21 PM
glebius committed rS353336: Revert changes to rip6_bind() from r353292. This function is always.
Revert changes to rip6_bind() from r353292. This function is always
Wed, Oct 9, 5:52 AM

Tue, Oct 8

glebius committed rS353314: Remove epoch assertion from if_setlladdr(). Originally this function was.
Remove epoch assertion from if_setlladdr(). Originally this function was
Tue, Oct 8, 5:56 PM
glebius updated the summary of D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Tue, Oct 8, 5:34 PM
glebius retitled D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker. from Correct and final KBI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker. to Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Tue, Oct 8, 5:34 PM
glebius retitled D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker. from Correct and final ABI to traverse through interface address lists for drivers. Removal of not stack allocated epoch_tracker. to Correct and final KBI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Tue, Oct 8, 5:33 PM
glebius created D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..
Tue, Oct 8, 5:31 PM
glebius committed rS353313: Quickly plug another regression from r353292. Again, multicast locking needs.
Quickly plug another regression from r353292. Again, multicast locking needs
Tue, Oct 8, 4:59 PM
glebius committed rS353312: In DIAGNOSTIC block of if_delmulti_ifma_flags() enter the network epoch..
In DIAGNOSTIC block of if_delmulti_ifma_flags() enter the network epoch.
Tue, Oct 8, 4:46 PM

Mon, Oct 7

glebius committed rS353292: Widen NET_EPOCH coverage..
Widen NET_EPOCH coverage.
Mon, Oct 7, 10:40 PM

Thu, Oct 3

glebius committed rS353030: Fix build failure from r353026. Somehow module build allowed this..
Fix build failure from r353026. Somehow module build allowed this.
Thu, Oct 3, 4:42 AM
glebius committed rS353027: Protect access to seq->xwin[] with the seq mutex..
Protect access to seq->xwin[] with the seq mutex.
Thu, Oct 3, 2:35 AM
glebius closed D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links.
Thu, Oct 3, 2:33 AM
glebius committed rS353026: - Remove the compile time limit for number of links a ng_bridge node.
- Remove the compile time limit for number of links a ng_bridge node
Thu, Oct 3, 2:33 AM

Mon, Sep 30

glebius added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

Hi,
I see wrappers are missing for WLAN:
net80211/ieee80211_input.c: ifp->if_input(ifp, m);
net80211/ieee80211_hostap.c: ifp->if_input(ifp, m);
??

Mon, Sep 30, 8:53 PM
glebius accepted D21803: netgraph/ng_bridge: Replace NG_BRIDGE_MAX_LINKS with unlimited links.
Mon, Sep 30, 8:46 PM

Sun, Sep 29

glebius added inline comments to D21179: Add header definition for RFC4340, Datagram Congestion Control Protocol.
Sun, Sep 29, 5:24 AM

Sat, Sep 28

glebius added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

@gallatin yes, I already got a branch that does this. Create it for Olivier Cochard's benchmarking of ipfw. https://github.com/glebius/FreeBSD/tree/net_epoch+IFF_KNOWSEPOCH+pfil

Sat, Sep 28, 12:04 AM

Fri, Sep 27

glebius added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

@bz That's fine, no hurry. I'm not sure that enter/exit points are 100% matching for VNETs. For example there is nothing wrong for a packet to travel between VNETs within one epoch.

Fri, Sep 27, 7:16 PM
glebius added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

@hselasky Good catch, thanks.

Fri, Sep 27, 7:14 PM
glebius added a reviewer for D19111: Summary: widen net_epoch coverage up to all packet processing: bz.
Fri, Sep 27, 7:12 PM
glebius updated the diff for D19111: Summary: widen net_epoch coverage up to all packet processing.
  • Enter the net_epoch in uether_rxflush(). While here, rewrite the whole
Fri, Sep 27, 7:12 PM
glebius added inline comments to D19111: Summary: widen net_epoch coverage up to all packet processing.
Fri, Sep 27, 6:56 PM

Thu, Sep 26

glebius added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

I'd like to go forward with this change. It will bring a number of new epoch recursions, that don't exist today, but I want to resolve them separately, one per subsystem, otherwise the changeset will get bigger and more messy. I need your review, guys. :)

Thu, Sep 26, 10:13 PM
glebius added reviewers for D19111: Summary: widen net_epoch coverage up to all packet processing: hselasky, kp, gallatin.
Thu, Sep 26, 10:11 PM
glebius updated the diff for D19111: Summary: widen net_epoch coverage up to all packet processing.
  • WIP: compiles, boots in VM
  • Enter epoch in DAD timer.
  • Revert entering epoch for setsockopt. This needs to be fine grained.
  • - In pfi_initialize_vnet() rely on IFNET_RLOCK() which is sx(9) for
  • Revert if_purgeaddrs() change. This function is called in control path.
  • Enter epoch for duration of ip6_output() just as we do for IPv4.
  • Enter epoch in route_output().
  • Revert this branch changes to in6_joingroup_locked(). Function can
  • Another ND6 timer.
  • Enter epoch before calling nd6_prefix_onlink() and nd6_lookup().
  • pfi_kif_update() now requires epoch.
  • Resolve rebase glitch.
  • Revert back defrouter_select_fib().
  • Fix few lock order issues.
  • Revert changes to ifa_maintain_loopback_route().
  • Merge remote-tracking branch 'FreeBSD/master' into net_epoch
  • Merge branch 'epoch-trace' into net_epoch
  • Merge branch 'epoch-trace' into net_epoch
  • Merge branch 'master' into net_epoch
  • Catch up on c6f2373c081e1431319aefa29218d59c1d01ff30.
  • Fix mismerge.
  • Merge remote-tracking branch 'FreeBSD/master' into net_epoch
  • Restore whitespace to what we have in head.
  • Merge remote-tracking branch 'FreeBSD/master' into net_epoch
Thu, Sep 26, 10:03 PM
glebius committed rS352778: Move EPOCH_TRACE to opt_global.h, so that any external modules that.
Move EPOCH_TRACE to opt_global.h, so that any external modules that
Thu, Sep 26, 9:13 PM

Wed, Sep 25

glebius committed rS352725: style(9): remove extraneous empty lines.
style(9): remove extraneous empty lines
Wed, Sep 25, 8:46 PM
glebius committed rS352707: Add debugging facility EPOCH_TRACE that checks that epochs entered are.
Add debugging facility EPOCH_TRACE that checks that epochs entered are
Wed, Sep 25, 6:26 PM
glebius committed rS352702: Enhance the 'ps' command so that it prints a line per proc and a line.
Enhance the 'ps' command so that it prints a line per proc and a line
Wed, Sep 25, 6:03 PM

Tue, Sep 24

glebius updated the diff for D21610: EPOCH tracing support for debugging..
  • Merge remote-tracking branch 'FreeBSD/master' into epoch-trace
  • More from Hans's review.
Tue, Sep 24, 9:19 PM
glebius added inline comments to D21610: EPOCH tracing support for debugging..
Tue, Sep 24, 5:31 PM
glebius added inline comments to D21610: EPOCH tracing support for debugging..
Tue, Sep 24, 12:27 AM

Sep 13 2019

glebius committed rS352311: Drivers may pass runt packets to filter. This is okay..
Drivers may pass runt packets to filter. This is okay.
Sep 13 2019, 10:36 PM
glebius updated the diff for D21610: EPOCH tracing support for debugging..
  • Improve per Hans's suggestions.
Sep 13 2019, 9:28 PM
glebius added inline comments to D21610: EPOCH tracing support for debugging..
Sep 13 2019, 9:26 PM

Sep 11 2019

glebius created D21610: EPOCH tracing support for debugging..
Sep 11 2019, 9:40 PM

Sep 10 2019

glebius committed rS352116: Fix 'calendar -a' in several ways..
Fix 'calendar -a' in several ways.
Sep 10 2019, 4:22 AM
glebius committed rS352115: Remove pointless playing with LC_TIME, which should have been done in r205821..
Remove pointless playing with LC_TIME, which should have been done in r205821.
Sep 10 2019, 4:01 AM

Aug 30 2019

glebius committed rS351616: Use mbuf queue instead of ifqueue in USB network drivers..
Use mbuf queue instead of ifqueue in USB network drivers.
Aug 30 2019, 12:05 AM
glebius committed rS351615: Allow mbuf queues to be unlimited..
Allow mbuf queues to be unlimited.
Aug 30 2019, 12:04 AM

Aug 16 2019

glebius added inline comments to D21277: Add kernel-side support for in-kernel TLS..
Aug 16 2019, 6:21 PM