Differential D54088

ip6: Add explicit lock order information to catch boot-time LOR
ClosedPublic
Actions

Authored by jtl on Fri, Dec 5, 5:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 30, 7:57 AM

	Unknown Object (File)
	Tue, Dec 23, 11:25 PM

	Unknown Object (File)
	Thu, Dec 18, 3:21 AM

	Unknown Object (File)
	Mon, Dec 15, 9:24 AM

	Unknown Object (File)
	Fri, Dec 12, 6:06 PM

	Unknown Object (File)
	Fri, Dec 12, 1:08 PM

	Unknown Object (File)
	Thu, Dec 11, 8:13 PM

	Unknown Object (File)
	Wed, Dec 10, 8:18 PM

View All 13 Files

Subscribers

Details

Reviewers

glebius
markj
bz

Group Reviewers

transport
network

Commits

rG3f10e5985044: ip6: Add explicit lock order information to catch LOR

Summary

Over the past several years, we have had sporadic reports of a boot-time LOR between the tcphash lock and the in6_ifaddr_lock. These seems to be hard to reproduce reliably, and the WITNESS backtrace points to code which uses the correct locking order.

Adding the lock order explicitly should help us detect the call stack which uses the incorrect locking order.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.Fri, Dec 5, 5:29 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Dec 5, 5:29 PM

jtl requested review of this revision.Fri, Dec 5, 5:29 PM

glebius accepted this revision as: glebius.Fri, Dec 5, 5:35 PM

This revision is now accepted and ready to land.Fri, Dec 5, 5:35 PM

Just FYI, at least my nightly incarnation wasn't "boot-time".

Closed by commit rG3f10e5985044: ip6: Add explicit lock order information to catch LOR (authored by jtl). · Explain WhySat, Dec 6, 7:59 PM

This revision was automatically updated to reflect the committed changes.

jtl added a commit: rG3f10e5985044: ip6: Add explicit lock order information to catch LOR.

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

Diff 167653

sys/kern/subr_witness.c

Loading...