Differential D54088

ip6: Add explicit lock order information to catch boot-time LOR
ClosedPublic
Actions

Authored by jtl on Dec 5 2025, 5:29 PM.

Tags

None

Referenced Files

	F162810104: D54088.diff
	Fri, Jul 17, 3:24 AM

	Unknown Object (File)
	Wed, Jul 15, 6:57 AM

	Unknown Object (File)
	Wed, Jul 15, 6:57 AM

	Unknown Object (File)
	Sun, Jul 5, 9:06 AM

	Unknown Object (File)
	Sat, Jul 4, 12:15 AM

	Unknown Object (File)
	Thu, Jul 2, 11:21 AM

	Unknown Object (File)
	Mon, Jun 29, 3:27 AM

	Unknown Object (File)
	Sun, Jun 21, 11:52 PM

View All 48 Files

Subscribers

Details

Reviewers

glebius
markj
bz

Group Reviewers

transport
network

Commits

rG3f10e5985044: ip6: Add explicit lock order information to catch LOR

Summary

Over the past several years, we have had sporadic reports of a boot-time LOR between the tcphash lock and the in6_ifaddr_lock. These seems to be hard to reproduce reliably, and the WITNESS backtrace points to code which uses the correct locking order.

Adding the lock order explicitly should help us detect the call stack which uses the incorrect locking order.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jtl created this revision.Dec 5 2025, 5:29 PM

Herald added subscribers: olce, imp. · View Herald TranscriptDec 5 2025, 5:29 PM

jtl requested review of this revision.Dec 5 2025, 5:29 PM

glebius accepted this revision as: glebius.Dec 5 2025, 5:35 PM

This revision is now accepted and ready to land.Dec 5 2025, 5:35 PM

Just FYI, at least my nightly incarnation wasn't "boot-time".

Closed by commit rG3f10e5985044: ip6: Add explicit lock order information to catch LOR (authored by jtl). · Explain WhyDec 6 2025, 7:59 PM

This revision was automatically updated to reflect the committed changes.

jtl added a commit: rG3f10e5985044: ip6: Add explicit lock order information to catch LOR.

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

Diff 167653

sys/kern/subr_witness.c

Loading...