This shrinks the structure a bit. Should be no functional change.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 69031 Build 65914: arc lint + arc unit
Event Timeline
| sys/net/bpf.c | ||
|---|---|---|
| 1511 | With this revision I don't intend to fix any bugs, just make struct smaller and make it possible to pass flags to bif_write method. | |
| sys/net/bpf.c | ||
|---|---|---|
| 1511 | Ok, but you're also introducing new bugs. Before, the code was performing unsynchronized stores to different fields. Now they are doing read-modify-writes to the same field, so setting one flag might clobber a different one. That wasn't possible before. | |
Comment Actions
The d_promisc appears to be locked by the global BPF_LOCK(). Thus, remove it
from this changes. This addresses Mark's comments.