Paths

Table of Contentst

Differential D53868

bpf: calculate net.bpf.stats buffer size dynamically
ClosedPublic
Actions

Authored by glebius on Nov 21 2025, 10:56 PM.

Tags

None

Referenced Files

	F164697816: D53868.id167070.diff
	Mon, Aug 3, 5:55 AM

	Unknown Object (File)
	Mon, Aug 3, 12:56 AM

	Unknown Object (File)
	Sun, Aug 2, 1:33 AM

	Unknown Object (File)
	Sat, Aug 1, 1:22 AM

	Unknown Object (File)
	Thu, Jul 30, 4:59 PM

	Unknown Object (File)
	Thu, Jul 30, 7:21 AM

	Unknown Object (File)
	Tue, Jul 28, 7:09 PM

	Unknown Object (File)
	Tue, Jul 28, 5:42 PM

View All 84 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG845896655815: bpf: calculate net.bpf.stats buffer size dynamically

Summary

This removed the global counter, that was updated in a racy manner.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Nov 21 2025, 10:56 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptNov 21 2025, 10:56 PM

glebius requested review of this revision.Nov 21 2025, 10:56 PM

Harbormaster completed remote builds in B68794: Diff 166928.Nov 21 2025, 10:56 PM

glebius added a parent revision: D53867: bpf: retire struct bpf_if_ext.Nov 21 2025, 10:56 PM

glebius added a child revision: D53869: bpf: global bpf list doesn't need CK.

markj added a subscriber: markj.Nov 24 2025, 10:13 PM

markj added inline comments.

sys/net/bpf.c
3091	Why not allocate `bpfd_cnt * sizeof(*xbd)` bytes instead? `req->oldlen` is not clamped, I believe, so userspace can request any allocation size they want.

Apply Mark's suggestion

Harbormaster completed remote builds in B68836: Diff 167070.Nov 25 2025, 6:05 AM

glebius marked an inline comment as done.Nov 25 2025, 6:05 AM

markj accepted this revision as: markj.Nov 25 2025, 2:00 PM

markj added inline comments.

sys/net/bpf.c
3094	To be useful, this assertion should be inside the inner loops below.

This revision is now accepted and ready to land.Nov 25 2025, 2:00 PM

Closed by commit rG845896655815: bpf: calculate net.bpf.stats buffer size dynamically (authored by glebius). · Explain WhyDec 3 2025, 11:20 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG845896655815: bpf: calculate net.bpf.stats buffer size dynamically.

Revision Contents
Changeset List

Path

Size

sys/

net/

28 lines

Diff 167508

sys/net/bpf.c

Loading...