tcp: don't set flowid in tcp_input()
ClosedPublic
Actions

Authored by glebius on Nov 22 2025, 6:53 PM.

Details

Reviewers

gallatin
tuexen

Group Reviewers

transport

Commits

rGee18f8be2165: tcp: don't set flowid in tcp_input()

Summary

With dd0e6bb996dc setting it always on connect(2) and syncache always
picking up the flowid from the incoming packet, any ESTABLISHED connection
shall have the flowid already set.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Nov 22 2025, 6:53 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 22 2025, 6:53 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B68812: Diff 166978.Nov 22 2025, 6:53 PM

glebius requested review of this revision.Nov 22 2025, 6:53 PM

glebius added a parent revision: D51792: tcp: store flowid info in syncache.

Would it make sense to replace the code with a KASSERT, that ensures that the inp_flowtype is not M_HASHTYPE_NONE on non-listening socket.

This revision is now accepted and ready to land.Nov 23 2025, 9:00 AM

gallatin accepted this revision.Nov 24 2025, 12:55 AM

Closed by commit rGee18f8be2165: tcp: don't set flowid in tcp_input() (authored by glebius). · Explain WhyDec 3 2025, 11:20 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGee18f8be2165: tcp: don't set flowid in tcp_input().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

31 lines

Diff 167506

View Options

tcp: don't set flowid in tcp_input()ClosedPublicActions