unix: Make sure we signal EOF on the write side when disconnecting
ClosedPublic
Actions

Authored by markj on Fri, May 1, 11:06 PM.

Details

Reviewers

Commits

rG037b285b80e5: unix: Make sure we signal EOF on the write side when disconnecting
rGf06697907f36: unix: Make sure we signal EOF on the write side when disconnecting
rG476805133f57: unix: Make sure we signal EOF on the write side when disconnecting

Summary

Add a regression test.

Fixes: d15792780760 ("unix: new implementation of unix/stream & unix/seqpacket")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Fri, May 1, 11:06 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, May 1, 11:06 PM

markj requested review of this revision.Fri, May 1, 11:06 PM

Harbormaster completed remote builds in B72714: Diff 177023.Fri, May 1, 11:06 PM

Avoid testing uninitialized memory in the nfds == 0 case, I think this was
a preexisting bug in the test code.

Harbormaster completed remote builds in B72718: Diff 177029.Sat, May 2, 12:01 AM

Mark, thanks a lot for fixing that. I just started to investigate yesterday, but you were faster. Thanks!

This revision is now accepted and ready to land.Sat, May 2, 3:05 PM

decke added a subscriber: decke.Sun, May 3, 8:43 PM

Closed by commit rG476805133f57: unix: Make sure we signal EOF on the write side when disconnecting (authored by markj). · Explain WhySun, May 3, 11:09 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG476805133f57: unix: Make sure we signal EOF on the write side when disconnecting.

markj added a commit: rGf06697907f36: unix: Make sure we signal EOF on the write side when disconnecting.Sat, May 9, 7:25 PM

cperciva added a commit: rG037b285b80e5: unix: Make sure we signal EOF on the write side when disconnecting.Sat, May 9, 8:44 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_usrreq.c

2 lines

tests/

sys/

kern/

unix_stream.c

77 lines

Diff 177107

View Options

sys/kern/uipc_usrreq.c