Page MenuHomeFreeBSD
Differential D56764

unix: Make sure we signal EOF on the write side when disconnecting
ClosedPublic
Actions

Authored by markj on May 1 2026, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 5, 1:11 AM
Unknown Object (File)
Thu, Jun 4, 11:11 AM
Unknown Object (File)
Thu, Jun 4, 11:11 AM
Unknown Object (File)
Tue, May 26, 3:24 PM
Unknown Object (File)
Tue, May 26, 3:15 PM
Unknown Object (File)
Tue, May 26, 2:19 PM
Unknown Object (File)
Tue, May 26, 2:11 PM
Unknown Object (File)
Tue, May 26, 1:04 AM
View All 37 Files
Subscribers
decke
imp
olce

Details

Reviewers
glebius
Commits
rG037b285b80e5: unix: Make sure we signal EOF on the write side when disconnecting
rGf06697907f36: unix: Make sure we signal EOF on the write side when disconnecting
rG476805133f57: unix: Make sure we signal EOF on the write side when disconnecting
Summary

Add a regression test.

Fixes: d15792780760 ("unix: new implementation of unix/stream & unix/seqpacket")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72718
Build 69601: arc lint + arc unit

Event Timeline

markj created this revision.May 1 2026, 11:06 PM
Herald added subscribers: olce, imp. · View Herald TranscriptMay 1 2026, 11:06 PM
markj requested review of this revision.May 1 2026, 11:06 PM
Harbormaster completed remote builds in B72714: Diff 177023.May 1 2026, 11:06 PM
markj updated this revision to Diff 177029.May 2 2026, 12:01 AM

Avoid testing uninitialized memory in the nfds == 0 case, I think this was
a preexisting bug in the test code.

Harbormaster completed remote builds in B72718: Diff 177029.May 2 2026, 12:01 AM
glebius accepted this revision.May 2 2026, 3:05 PM

Mark, thanks a lot for fixing that. I just started to investigate yesterday, but you were faster. Thanks!

This revision is now accepted and ready to land.May 2 2026, 3:05 PM
decke added a subscriber: decke.May 3 2026, 8:43 PM
Closed by commit rG476805133f57: unix: Make sure we signal EOF on the write side when disconnecting (authored by markj). · Explain WhyMay 3 2026, 11:09 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG476805133f57: unix: Make sure we signal EOF on the write side when disconnecting.
markj added a commit: rGf06697907f36: unix: Make sure we signal EOF on the write side when disconnecting.Sat, May 9, 7:25 PM
cperciva added a commit: rG037b285b80e5: unix: Make sure we signal EOF on the write side when disconnecting.Sat, May 9, 8:44 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines
tests/
sys/
kern/
77 lines

Diff 177029

View Options

sys/kern/uipc_usrreq.c

Loading...
View Options

tests/sys/kern/unix_stream.c

Loading...