Somehow I ended up with making the very similarly named
unp_connectat_peer() and unp_connect_peer(), but the functions are
not similar at all!
unp_connectat_peer() connects nothing: it turns a descriptor and a
pathname into a referenced peer socket. It is the one that never should
have had that name. The other one actually does connect, and therefore
deserves it.
(Presumably at some point me or the LLM got confused whether the naming
reflected what we were doing ("connecting"), or who was calling us
("connectat").)
The new name also sits better beside the helpers it dispatches to,
unp_socket_fd_peer(), unp_dupfd_peer() and unp_vnode_peer(), which
are likewise named for what they resolve from.
While here, fix the comment: it described 'buf' as "null when len == 0",
but an empty path is an empty string, not a NULL pointer.
No functional change intended.
Signed-off-by: John Ericson <John.Ericson@Obsidian.Systems>
Assisted-by: Claude Code (Claude Opus 5)