Page MenuHomeFreeBSD

net/bong-kmods: Add port
Needs ReviewPublic

Authored by dave_freedave.net on Thu, Apr 30, 11:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 6, 11:47 PM
Unknown Object (File)
Tue, May 5, 3:14 PM
Unknown Object (File)
Mon, May 4, 12:05 PM
F155372210: bong-kmods-2026.05.03.1500506.log
Sun, May 3, 10:11 PM
Unknown Object (File)
Sun, May 3, 8:07 PM
Unknown Object (File)
Sat, May 2, 2:42 PM

Details

Reviewers
adamw
Group Reviewers
Contributor Reviewers (ports)
Summary

These are netgraph kernel modules I maintain outside src.
While I still have other modules I'm working on, but the existing modules have been stable for months.

I saw 292993 go by recently. Not the first issue with vnet(9) + netgraph(4) with if_vmove. And this port has the wormhole which removes the need for if_vmove entirely would be another solution for users.

Test Plan

I run these nodes and test them on stable/14, stable/15, and CURRENT. However they require patches for stable/14 and the port requires at least stable/15.

Rather than repeat myself you can look at the old src review: D50244

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dave_freedave.net created this revision.

Why the name "bong"?

net/bong-kmods/Makefile
22

Why a hash instead of tagging a release?

24

What are these MAKE_ARGS doing?

Dave, I'm very sorry for not looking at your earlier submissions. Trust me, this is not a reluctance to add them to the src, but just a lack of time. Would you like me to review your nodes on github or would you prefer to refresh the phabricator revisions where you suggested the nodes to add to src? I will try to find some time.

Why the name "bong"?

[B]ag [O]f [N]et{G]raph.
Didn't even get my own acronym right the first time!

Dave, I'm very sorry for not looking at your earlier submissions. Trust me, this is not a reluctance to add them to the src, but just a lack of time. Would you like me to review your nodes on github or would you prefer to refresh the phabricator revisions where you suggested the nodes to add to src? I will try to find some time.

I tagged so you and zlei for awareness so the next time a vnet + netgraph + if_vmove comes along you have an alternate to point people at. I would love for you to take a look as I value your opinion!

But bong-kmods has 2 nodes I never put up for review: ng_pcap(4) and ng_ula4tag(4). And I have 3 more more to make ... I feel like ports are a good place for these to at least start.

net/bong-kmods/Makefile
24

What are these MAKE_ARGS doing?

I need to verify they are needed again. But uidfix doesn't do the permissions for MANINSTALL which get's used to "build" (gzip) and install man pages from /usr/share/mk/bsd.*.mk machinery.

Will verify necessary, and if not remove.

Why the name "bong"?

[B]ag [O]f [N]et{G]raph.
Didn't even get my own acronym right the first time!

"Bag of Netgraph"... That's really clever! I like that a lot.

I just want to make sure that you've thought through and are okay with the implications. I'd suggest at least putting its name in the descr so people know it's not just named after drug paraphernalia.

  • removed GH_TAGNAME, gave calver release tag
  • removed MAKE_ARGS, not required
  • update pkg-descr, add the acronym that explains port name

poudriere testport -j FreeBSD15 -p local net/bong-kmods output:

@adamw You will notice this in my make.conf from log above:

.if ${OSVERSION:U0} > 1600000
net_bong-kmods_SET+=»   INVARIANTS
.endif

That is so my kernel builds don't get confused but so that poudriere(8) builds for CURRENT automatically set INVARIANTS because that is the default way CURRENT builds. But any kernel can have INVARIANTS enabled. I didn't see any better option from 286717 to handle this.

If the only outstanding issue is the name, I am fine renaming the port.