Page MenuHomeFreeBSD

net/bong-utils: Add port
Needs ReviewPublic

Authored by dave_freedave.net on Thu, Apr 30, 11:44 AM.

Details

Reviewers
adamw
Summary

This adds utilities for working with the netgraph nodes provided in net/bong-kmods.

Test Plan

I use jeiface and ngportal via jail.conf to create and destroy numerous wormholes per day.
I use ngpcap while developing new netgraph nodes.

Rather than go through everything I'll point back to D50245

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dave_freedave.net created this revision.
net/bong-utils/Makefile
21

I mean, if it needs exactly those two to build and exactly those two to run, then I absolutely get the intent. It's not wrong per se, but I want you to think it through first.

Ask yourself: what situation are you guarding against?

Let's say bong-kmods is installed but the first header is missing. What will the framework do when it goes to build this port?

27

As in bong-kmods, why a hash instead of tagging a release?

29

What does this line accomplish?

net/bong-utils/Makefile
21

Yeah I have a long history with more primitive implementations of make. With those the right thing was always to give make as much info as possible and let it decide. But only one is needed will fix

27

yeah I'll go make some tags. I got no reason not to.

29

nothing. and it will be pulled out of both. funny (now) story. i didn't see uidfix and was manually changing my makefiles so that UID/GID wouldn't blow up. I somehow missed uidfix when looking at other examples. I had patches for every makefile before I saw that.