inpcb: allow to specify different sizes for port and load balance hashes
ClosedPublic
Actions

Authored by glebius on Tue, Apr 28, 9:25 PM.

Details

Reviewers

Group Reviewers

network
transport

Commits

rG6883b120c537: inpcb: allow to specify different sizes for port and load balance hashes

Summary

Understand zero size as instruction to not allocate the hash. Do not
allocate both hashes for rawip(4). There are no functional changes to TCP
or UDP.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Tue, Apr 28, 9:25 PM

Herald added a reviewer: transport. · View Herald TranscriptTue, Apr 28, 9:25 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Tue, Apr 28, 9:25 PM

Harbormaster completed remote builds in B72630: Diff 176766.Tue, Apr 28, 9:25 PM

glebius added a parent revision: D56482: inpcb: improve some internal function names.Tue, Apr 28, 9:25 PM

markj accepted this revision.Wed, Apr 29, 2:19 PM

markj added inline comments.Wed, Apr 29, 2:25 PM

sys/netinet/in_pcb.c
414	We really want a macro to wrap this I think.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Apr 29, 4:20 PM

Closed by commit rG6883b120c537: inpcb: allow to specify different sizes for port and load balance hashes (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG6883b120c537: inpcb: allow to specify different sizes for port and load balance hashes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

5 lines

37 lines

2 lines

2 lines

5 lines

Diff 176815

View Options

sys/netinet/in_pcb.h

View Options

sys/netinet/in_pcb.c

View Options

sys/netinet/raw_ip.c

View Options

sys/netinet/tcp_subr.c

View Options

inpcb: allow to specify different sizes for port and load balance hashesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 176815

sys/netinet/in_pcb.h

sys/netinet/in_pcb.c

sys/netinet/raw_ip.c

sys/netinet/tcp_subr.c

sys/netinet/udp_usrreq.c

inpcb: allow to specify different sizes for port and load balance hashes
ClosedPublic
Actions

Revision Contents
Changeset List