inpcb: remove always true condition in in_pcblookup_local()
ClosedPublic
Actions

Authored by glebius on Apr 18 2026, 1:21 AM.

Details

Reviewers

markj
pouria

Group Reviewers

network

Commits

rG14a47a8bed87: inpcb: remove always true condition in in_pcblookup_local()

Summary

We are searching through the hash that has only wildcard bindings.
This was missed by fdb987bebddf05e15a5af840379c7715a94aec1c.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Apr 18 2026, 1:21 AM

Herald added a reviewer: pouria. · View Herald TranscriptApr 18 2026, 1:21 AM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

glebius requested review of this revision.Apr 18 2026, 1:21 AM

glebius added a parent revision: D56482: inpcb: improve some internal function names.

Harbormaster completed remote builds in B72309: Diff 175810.Apr 18 2026, 1:21 AM

glebius added a child revision: D56489: inpcb: remove port hash and relax port "stealing" constraint.Apr 18 2026, 1:23 AM

markj accepted this revision.Apr 18 2026, 12:15 PM

This revision is now accepted and ready to land.Apr 18 2026, 12:15 PM

BTW, I regret calling this table "wild". "unconnected" would be much clearer. I wonder if you want to change this as part of your work in this area?

I actually like "wild". The "unconnected" is already used for inpcbs that are not put into any hash, e.g. right after socket(2).

Closed by commit rG14a47a8bed87: inpcb: remove always true condition in in_pcblookup_local() (authored by glebius). · Explain WhyApr 21 2026, 4:12 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG14a47a8bed87: inpcb: remove always true condition in in_pcblookup_local().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

3 lines

netinet6/

in6_pcb.c

3 lines

Diff 176016

View Options

sys/netinet/in_pcb.c