nvme: replace bus_space_[read|write]_4 with bus_[read|write]_4

[ziaee]

Summary

The goal this change is to remove the use of the tag and handle
needed by bus_space_[read|write]_4.

Proxying on behalf of Matt Delco <[e-mail]>
Requested by: jhb

[jrtc27]

sys/dev/nvme/nvme_private.h

328–340

Worth reformatting the code as part of it given they now fit on fewer lines, and whilst here, can fix the missing spaces around +, and the missing parentheses around val for nvme_mmio_write_8

[jrtc27]

sys/dev/nvme/nvme_private.h

328–340

(Phabricator mangles the whitespace, but an editor that visually distinguishes between tabs and spaces, and has a tab width of 8, should make it clear)

[jhb]

When committing, you can just use Matt's name as the commit author (you will still be the committer). I agree with Jess on reformatting the macros.

[ziaee]

Attempt to improve whitespace. I'm not sure if I'm understanding @jrtc27's whitespace suggestion but also I've never done this part of it before.

When committing, you can just use Matt's name as the commit author (you will still be the committer). I agree with Jess on reformatting the macros.

Of course. Please note I merged over a hundred contributor reviews and believe I have never messed this up. I did however once misattribute emaste to having reviewed something that he did not, which still stings, though I do not believe he held it against me.

Thanks so much for helping with this!

[jrtc27]

One tiny missing space, otherwise LGTM, feel free to fix on commit

sys/dev/nvme/nvme_private.h

332