Page MenuHomeFreeBSD

nvme: removed unused 'regs' variable
ClosedPublic

Authored by ziaee on Mar 11 2026, 8:54 PM.
Tags
None
Referenced Files
F155982171: D55817.id173588.diff
Sun, May 10, 2:25 AM
F155980975: D55817.id173588.diff
Sun, May 10, 2:19 AM
Unknown Object (File)
Sun, May 3, 2:36 AM
Unknown Object (File)
Sun, May 3, 2:27 AM
Unknown Object (File)
Wed, Apr 29, 1:13 AM
Unknown Object (File)
Wed, Apr 29, 1:07 AM
Unknown Object (File)
Mon, Apr 27, 8:38 PM
Unknown Object (File)
Mon, Apr 27, 10:47 AM
Subscribers

Details

Summary

The private struct has a 'regs' member that's only written to
and otherwise unused. This change removes it.

Proxying on behalf of Matt Delco <delco@google.com>

Requested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee requested review of this revision.Mar 11 2026, 8:54 PM

Yes. We only use struct nvme_registers for register offsets, and otherwise use bus space to get the data.

This revision is now accepted and ready to land.Mar 11 2026, 9:25 PM

Great that we already use bus_space. I feared the worst when I saw this assignment fly by in the earlier diff.

This revision was automatically updated to reflect the committed changes.