Page MenuHomeFreeBSD

nvme: removed unused 'regs' variable
AcceptedPublic

Authored by ziaee on Wed, Mar 11, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 12, 6:47 AM
Unknown Object (File)
Thu, Mar 12, 2:50 AM
Subscribers

Details

Summary

The private struct has a 'regs' member that's only written to
and otherwise unused. This change removes it.

Proxying on behalf of Matt Delco <delco@google.com>

Requested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71351
Build 68234: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Wed, Mar 11, 8:54 PM

Yes. We only use struct nvme_registers for register offsets, and otherwise use bus space to get the data.

This revision is now accepted and ready to land.Wed, Mar 11, 9:25 PM

Great that we already use bus_space. I feared the worst when I saw this assignment fly by in the earlier diff.