Differential D56427

mlx5e: Ensure rx timestamps are monotonically increasing
ClosedPublic
Actions

Authored by gallatin on Thu, Apr 16, 1:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 18, 7:49 AM

	Unknown Object (File)
	Sat, Apr 18, 7:49 AM

	Unknown Object (File)
	Sat, Apr 18, 7:49 AM

	Unknown Object (File)
	Sat, Apr 18, 6:12 AM

	Unknown Object (File)
	Thu, Apr 16, 4:09 PM

Subscribers

Details

Reviewers

kib
nickbanks_netflix.com

Commits

rGce33f96fcf2f: mlx5e: Ensure rx timestamps are monotonically increasing

Summary

The clock calibration routine currently can result in rx timestamps
jumping backwards, which can confuse the TCP stack.
Ensure they are monotonically increasing by estimating what
we'd calculate as the next timestamp and clamp the calibration
so new timestamps are no earlier in time.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gallatin created this revision.Thu, Apr 16, 1:26 PM

Herald added subscribers: ae, imp. · View Herald TranscriptThu, Apr 16, 1:26 PM

gallatin requested review of this revision.Thu, Apr 16, 1:26 PM

Tested this out and it reduced the backward time jumps, as measured by TCP connections, by >99.98% (down from 73,800 to 10).

This revision is now accepted and ready to land.Thu, Apr 16, 1:39 PM

kib accepted this revision.Thu, Apr 16, 2:32 PM

Closed by commit rGce33f96fcf2f: mlx5e: Ensure rx timestamps are monotonically increasing (authored by gallatin). · Explain WhyThu, Apr 16, 4:31 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rGce33f96fcf2f: mlx5e: Ensure rx timestamps are monotonically increasing.

Revision Contents
Changeset List

Path

Size

sys/

dev/

mlx5/

mlx5_en/

50 lines

Diff 175672

sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Loading...