Page MenuHomeFreeBSD
Differential D56509

iflib: fix book keeping
ClosedPublic
Actions

Authored by tuexen on Sat, Apr 18, 7:12 PM.
Tags
None
Referenced Files
F153194156: D56509.diff
Sun, Apr 19, 5:44 PM
F153193416: D56509.id.diff
Sun, Apr 19, 5:39 PM
Unknown Object (File)
Sun, Apr 19, 12:25 AM
Unknown Object (File)
Sat, Apr 18, 10:11 PM
Unknown Object (File)
Sat, Apr 18, 7:55 PM
Unknown Object (File)
Sat, Apr 18, 7:26 PM
Subscribers
adrian
ae
imp
melifaro

Details

Reviewers
gallatin
glebius
rrs
shurd
Group Reviewers
iflib
Commits
rGcca22c36c306: iflib: fix book keeping
Summary

iflib_txq_drain() returns the number of consumed entries. In the case of TSO, a single entry can contain multiple TCP packets.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Sat, Apr 18, 7:12 PM
Herald added a reviewer: shurd. · View Herald TranscriptSat, Apr 18, 7:12 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: melifaro, ae, imp. · View Herald Transcript
tuexen requested review of this revision.Sat, Apr 18, 7:12 PM
gallatin accepted this revision.Sat, Apr 18, 7:47 PM

Thank you for fixing this for me!

This revision is now accepted and ready to land.Sat, Apr 18, 7:47 PM
Closed by commit rGcca22c36c306: iflib: fix book keeping (authored by tuexen). · Explain WhySat, Apr 18, 8:05 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGcca22c36c306: iflib: fix book keeping.
adrian added a subscriber: adrian.Sat, Apr 18, 8:21 PM

(post commit) maybe its worth adding function documentation explaining what its supposed to be doing and returning?

Revision Contents
Changeset List

PathSize
sys/
net/
13 lines

Diff 175851

View Options

sys/net/iflib.c

Loading...