Page MenuHomeFreeBSD

Convert iflib(4) and iflib-based drivers to the DrvAPI
ClosedPublic

Authored by jhibbits on Dec 20 2022, 10:01 PM.
Tags
None
Referenced Files
F98364642: D37768.id114786.diff
Thu, Oct 3, 5:16 AM
Unknown Object (File)
Mon, Sep 30, 12:23 PM
Unknown Object (File)
Sat, Sep 14, 3:50 AM
Unknown Object (File)
Mon, Sep 9, 1:38 AM
Unknown Object (File)
Sep 3 2024, 2:26 AM
Unknown Object (File)
Aug 19 2024, 10:30 AM
Unknown Object (File)
Aug 13 2024, 8:25 PM
Unknown Object (File)
Jul 17 2024, 5:19 PM

Details

Reviewers
gallatin
mmacy
kbowling
shurd
Group Reviewers
network
Restricted Owners Package(Owns No Changed Paths)
iflib
Commits
rG402810d32e5f: Convert iflib(4) and iflib-based drivers to the DrvAPI
Summary

Convert iflib(4) and the following drivers:

  • axgbe
  • em
  • ice
  • ixl
  • vmxnet

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48782
Build 45671: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 20 2022, 10:01 PM
erj added inline comments.
sys/dev/ixl/ixl_iw.c
168

I think this needs to be adjusted

sys/dev/ixl/ixl_pf_main.c
621

Is it if_getname, or if_getxname? You use the former function in other places.

sys/dev/ixl/ixl_iw.c
168

How did this even pass the build?

I see why now, because the file is not even compiled.

sys/dev/ixl/ixl_pf_main.c
621

It should be if_name() instead. That's the KPI @melifaro likes, and I thought my sed fixed all of them.

sys/dev/ixl/ixl_iw.c
168

This file/functionality should probably be removed for 14, anyway.

sys/dev/ixl/ixl_pf_main.c
621

Ok, yeah, I see it's if_name() everywhere else; I think I just transposed the "get" there because most of these accessors use "get".

Hmm... this should've been closed already, but I can't close it without abandoning.

Was already pushed as 402810d32e5f7525c61ef70c6af24817227e1649.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 6 2023, 1:32 AM
This revision was automatically updated to reflect the committed changes.