Page MenuHomeFreeBSD

iflib: Create led(4) devices
ClosedPublic

Authored by kbowling on Oct 9 2021, 3:14 AM.
Tags
None
Referenced Files
F174910308: D32389.diff
Tue, Oct 6, 10:15 PM
Unknown Object (File)
Sun, Oct 4, 3:03 AM
Unknown Object (File)
Fri, Oct 2, 6:18 AM
Unknown Object (File)
Sat, Sep 26, 6:01 PM
Unknown Object (File)
Sat, Sep 26, 4:06 PM
Unknown Object (File)
Sat, Sep 26, 8:57 AM
Unknown Object (File)
Sat, Sep 26, 8:13 AM
Unknown Object (File)
Sat, Sep 26, 12:48 AM

Details

Summary

If the driver defines an led_func, have the framework create them during attach.

PR: 246885
Reported by: Jose Luis Duran <jlduran@gmail.com>

Test Plan

Tested on I350:
echo "f3" > /dev/led/igb0
echo "0" > /dev/led/igb0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Jose submitted a variant where the driver (e1000 in this case) calls the iflib_led_create() function in its post attach. I am open to either approach if anyone has any thoughts one way or the other.

I prefer this approach.

Regardless of which patch you choose, on my home router (2 i211-based NICs), identifying /dev/led/igb0 works, but /dev/led/igb1 do not.

Nevertheless, the LED devices are created as well. Thank you!

Seems ok. This kind of reflection looks a bit hacky but I see it used elsewhere. Probably we should have some kobj.h helper to do it.

sys/net/iflib.c
5440

And on the next line too.

5444
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2026, 2:11 AM
This revision was automatically updated to reflect the committed changes.