Page MenuHomeFreeBSD

Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration
ClosedPublic

Authored by fbsd_opal.com on Mar 4 2022, 11:42 PM.

Details

Summary

Currently if an em(4) interface is set to a fixed media configuration, for 1000b, it will participate in auto-negotiation as required by IEEE 802.3-2018 Clause 37.
However, if set to fixed media configuration for 100b or 10b, it does NOT participate in auto-negotiation.

By my reading of Clauses 28 and 37, while auto-negotiation is optional for 100b and 10b, it is not prohibited and is, in fact, "highly recommended".

This patch enables auto-negotiation for fixed 100b and 10b media configuration, in a similar manner to that already performed for 1000b. I.e., the patch enables advertising of just the manually configured settings with the goal of allowing the remote end to match the manually configured settings if it has them available.

To be clear, this patch does NOT allow an em(4) interface that has been manually configured with specific media settings to respond to auto-negotiation by then configuring different parameters to those that were manually configured. The intent of this patch is to fully comply with the requirements of Clause 37, but for 100b and 10b.

The need for this has arisen on an em(4) link where the other end is under a different administrative control and is set to full auto-negotiation. Due to the cable length GigE is not working well. It is desired to set the em(4) end to "media 100baseTX mediatype full-duplex" which does work when both ends are configured that way. Currently, because em(4) does not participate in autoneg for this setting, the remote defaults to half-duplex - i.e., there's a duplex mismatch and things don't work. With this patch, em(4) would inform the remote that it has only 100baseTX full, the remote would match that and it will work.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fbsd_opal.com created this revision.
erj edited reviewers, added: kbowling; removed: jfv.

Is anyone else going to look at this? This does seem alright to me, though I don't know how to answer the autoneg_wait_to_complete question.

This revision is now accepted and ready to land.Apr 12 2022, 8:18 PM

Thanks for your feedback, Eric.

I added the question about whether or not we need to set autoneg_wait_to_complete to FALSE in order to consider the case where em(4) would now attempt the autonegotiation dialog but the other end does not have autonegotiation capability, e.g., it is some old 10bt device. I was worried that waiting might cause things to block indefinitely.

On reading more of the code, especially e1000_phy.c e1000_copper_link_autoneg() and e1000_wait_autoneg(), I see the wait routines do include a timeout (currently 45 loop iterations with a 100ms delay). So waiting would not block indefinitely, but could cause a delay of up to 4.5s.

However, because the em(4) end has been manually configured to a specific setting, this means it will not be changing its configuration even if autonegotiation does take place. So, waiting would appear to be unnecessary.

I think hw->phy.autoneg_wait_to_complete is also set to false in the driver earlier in em_if_attach_pre() and never changes.