Page MenuHomeFreeBSD

jfv (Jack Vogel)
User

Projects

User Details

User Since
Dec 1 2014, 9:00 PM (246 w, 6 d)

Recent Activity

Aug 3 2015

jfv added a comment to D3282: Add capability to disable CRC stripping. This breaks IPMI/BMC capabilities on certain adatpers..

Cool, surprised this wasn't caught earlier :)

Aug 3 2015, 8:00 PM

Jul 24 2015

jfv accepted D3163: em(4): Add Skylake/I219 support..

Thanks for getting this in Eric.

Jul 24 2015, 7:28 PM
jfv added a comment to D3163: em(4): Add Skylake/I219 support..

The block of code that Sean asked about is basically something the hardware
team said needed to be added, they gave me no details, this is often the way
it goes Sean, sorry :)

Jul 24 2015, 7:27 PM

Jun 26 2015

jfv added a comment to D2050: ixl: Propagate link state changes to VFs.

Code got added because Jeff saw link changes not being visible in a VM,
I do not recall for sure if he tested a desk build, but things are certainly
broken without the code... so long as you've done basic sanity testing I
would commit it.

Jun 26 2015, 10:04 PM

Jun 6 2015

jfv committed rS284049: Update SW4 to the Intel ixl/ixlv drivers. This is primarily a shared.
Update SW4 to the Intel ixl/ixlv drivers. This is primarily a shared
Jun 6 2015, 10:52 PM

Jun 5 2015

jfv closed D2489: Intel 10G SRIOV support.

Integrated in r283883

Jun 5 2015, 10:41 PM

Jun 3 2015

jfv added a comment to D1994: Enable em(4) multiqueue as a compile time option.

The shared code changes just require some legal stuff if they are taken back into our code base, if you leave it as is we can cope with that later, its not like the E1000 shared code has a lot of churn at this point.

Jun 3 2015, 4:42 PM
jfv accepted D1994: Enable em(4) multiqueue as a compile time option.

Thanks for all the work you put into this Sean, go for it :)

Jun 3 2015, 4:27 PM

Jun 2 2015

jfv accepted D2019: Revamp em watchdog logic.
Jun 2 2015, 5:01 PM

Jun 1 2015

jfv committed rS283883: Delta D2489 - Add SRIOV support to the Intel 10G driver..
Delta D2489 - Add SRIOV support to the Intel 10G driver.
Jun 1 2015, 5:43 PM
jfv committed rS283882: Revert last commit, to remove added skeleton tree..
Revert last commit, to remove added skeleton tree.
Jun 1 2015, 5:35 PM
jfv committed rS283881: Delta D2489 - Add SRIOV support to the Intel 10G driver..
Delta D2489 - Add SRIOV support to the Intel 10G driver.
Jun 1 2015, 5:15 PM
jfv accepted D2019: Revamp em watchdog logic.
Jun 1 2015, 5:08 PM

May 15 2015

jfv added a comment to D2343: Fix properly commit r281773..

We removed these additional task creations with the intent purpose of
reducing lock contention for a customer as I recall, so unless you have a
good reason to add it back I would oppose doing so.

May 15 2015, 5:13 PM

May 11 2015

jfv updated the diff for D2489: Intel 10G SRIOV support.

Correct a couple minor points in the last revision.

May 11 2015, 6:36 PM
jfv added inline comments to D2489: Intel 10G SRIOV support.
May 11 2015, 6:25 PM

May 8 2015

jfv updated the diff for D2489: Intel 10G SRIOV support.

Remove x550 device that is not yet available. Also remove unneeded shared code prototype,
and some added whitespace.

May 8 2015, 5:55 PM
jfv updated D2489: Intel 10G SRIOV support.
May 8 2015, 5:27 PM
jfv retitled D2489: Intel 10G SRIOV support from to Intel 10G SRIOV support.
May 8 2015, 5:25 PM

May 7 2015

jfv retitled D2474: SW4 Update to the ixl driver from to SW4 Update to the ixl driver.
May 7 2015, 6:10 PM

Apr 29 2015

jfv accepted D2402: Adjust stat counters for Intel drivers..

Looks good, thanks much John!

Apr 29 2015, 8:38 PM

Apr 21 2015

jfv accepted D2296: Full 32bit flowid for igb(4).
Apr 21 2015, 6:28 PM
jfv added a comment to D2296: Full 32bit flowid for igb(4).

Change E1000_MRQC_ENABLE_RSS_4Q to E1000_MRQC_ENABLE_RSS_8Q, and the comment
to :

Apr 21 2015, 5:25 PM

Mar 27 2015

jfv closed D1580: Revamp ixgbe into seperate if_ix and if_ixv drivers.
Mar 27 2015, 7:34 AM

Mar 11 2015

jfv accepted D2050: ixl: Propagate link state changes to VFs.
Mar 11 2015, 9:42 PM
jfv accepted D2046: Fix races during ixl SR-IOV initialization.
Mar 11 2015, 4:18 PM

Mar 6 2015

jfv retitled D2019: Revamp em watchdog logic from to Revamp em watchdog logic.
Mar 6 2015, 6:53 PM

Mar 3 2015

jfv added a comment to D1994: Enable em(4) multiqueue as a compile time option.

The code is not acceptable as is right now, Eric and I are discussing changes.

Mar 3 2015, 12:38 AM

Feb 27 2015

jfv accepted D1977: Pad RX copy alignment calculation to avoid illegal memory accesses when copying custom mbuf structures.

Looks good.

Feb 27 2015, 6:09 PM

Feb 25 2015

jfv accepted D1965: Add extended media types to if_media.h and ifconfig.
Feb 25 2015, 10:26 PM
jfv accepted D1966: Add new media types to ixl.
Feb 25 2015, 10:24 PM

Feb 18 2015

jfv accepted D1881: Allow Illumos code to co-exist with nv(9).
Feb 18 2015, 10:30 PM
jfv accepted D1883: Move libnv into the kernel and hook it into the kernel build.
Feb 18 2015, 10:29 PM
jfv accepted D1882: Add macros to make code compile in kernel.
Feb 18 2015, 10:29 PM
jfv accepted D1880: Prevent creation of an invalid nvlist.
Feb 18 2015, 10:27 PM
jfv accepted D1879: Don't allocate memory for operations that do not insert.
Feb 18 2015, 10:27 PM
jfv accepted D1878: Add function to force an nvlist into the error state.
Feb 18 2015, 10:25 PM
jfv accepted D1877: Implement asprintf in libkern.
Feb 18 2015, 10:24 PM
jfv accepted D1876: Add tests for dnvlist_take_*.
Feb 18 2015, 10:23 PM
jfv accepted D1875: Add tests for dnv_get_*.
Feb 18 2015, 10:22 PM
jfv accepted D1874: Add tests for nvlist_free* functions.
Feb 18 2015, 10:22 PM
jfv accepted D1873: Add tests for nvlist_take_*.
Feb 18 2015, 10:21 PM
jfv accepted D1872: Add test cases for nvlist_move_*.
Feb 18 2015, 10:20 PM
jfv accepted D1871: Add tests for nvlist_pack/unpack.
Feb 18 2015, 10:20 PM
jfv accepted D1870: Add tests for nvlist_clone.
Feb 18 2015, 10:12 PM
jfv accepted D1869: Tests of basic nvlist add functions.
Feb 18 2015, 8:32 PM
jfv accepted D1868: Make libnv headers includable from C++.
Feb 18 2015, 7:59 PM
jfv accepted D1648: Add stubs for deprecated VC messages.
Feb 18 2015, 7:54 PM
jfv accepted D811: Incorrect media for INTEL X540T 10G..
Feb 18 2015, 7:27 PM
jfv accepted D823: Make ixgbe(4) set media as 10Gbase-T..
Feb 18 2015, 7:25 PM

Jan 29 2015

jfv accepted D1661: Add some security-related config parameters.
Jan 29 2015, 1:27 AM
jfv accepted D1660: Add support for mac-addr parameter.
Jan 29 2015, 1:25 AM
jfv accepted D1659: Register ixl as an SR-IOV-capable driver during attach.

can't wait to see the infrastructure in place :)

Jan 29 2015, 1:24 AM
jfv accepted D1658: Add sysctls for per-VF hardware counters.
Jan 29 2015, 1:20 AM
jfv accepted D1657: Allow VFs to run while the PF is admin down.
Jan 29 2015, 1:08 AM
jfv accepted D1656: Handle VFLR events from VFs.

Looks good. Again, will need real world testing when we have infrastructure.

Jan 29 2015, 1:06 AM
jfv accepted D1655: Add support for GET_STATS VC message.
Jan 29 2015, 1:02 AM
jfv accepted D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message.

No problems

Jan 29 2015, 12:59 AM
jfv accepted D1653: Add support for ADD/DEL_VLAN VC messages.

No issues.

Jan 29 2015, 12:54 AM
jfv accepted D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages.

Good.

Jan 29 2015, 12:23 AM
jfv accepted D1651: Add support for ENABLE/DISABLE_QUEUES VC messages.
Jan 29 2015, 12:21 AM
jfv accepted D1650: Add support for CONFIG_IRQ_MAP VC message.
Jan 29 2015, 12:20 AM
jfv accepted D1649: Add support for CONFIG_VSI_QUEUES VC message.

Don't see any problems.

Jan 29 2015, 12:15 AM

Jan 28 2015

jfv requested changes to D1648: Add stubs for deprecated VC messages.

Let's not mention Linux in our comments, either say nothing or think of something else :)

Jan 28 2015, 11:59 PM
jfv accepted D1647: Add support for GET_VF_RESOURCES VC message.

seems fine

Jan 28 2015, 11:54 PM
jfv accepted D1646: Add support for RESET_VF VC message.
Jan 28 2015, 11:52 PM
jfv accepted D1645: Add support for VERSION VC message.
Jan 28 2015, 11:13 PM
jfv accepted D1644: Add infrastructure for handling the VC msg channel from VFs.

Fine

Jan 28 2015, 11:04 PM
jfv accepted D1641: Implement PCI SR-IOV initialization methods.

Don't see any issues, of course the proof will come in the actual use when we
have the infrastructure :)

Jan 28 2015, 11:02 PM
jfv accepted D1642: Implement PCI SR-IOV method to initialize individual VFs.
Jan 28 2015, 11:00 PM
jfv accepted D1643: Implement resetting a VF.

See no problems.

Jan 28 2015, 10:58 PM
jfv added a comment to D1580: Revamp ixgbe into seperate if_ix and if_ixv drivers.
In D1580#6, @jhb wrote:

Can you provide more details on why you need to separate them (and why you need to rename them)? Note that a single kld can contain multiple drivers (like if_lem.c and if_em.c in if_em.ko).
I do think having the kld name match the interface is good (so the ifconfig auto-load magic works), but it's not clear to me why you can't just include the VF driver in the PF driver's module? (And renaming options in a kernel config is pretty disruptive, so there need to be good reasons.. People are probably still somewhat burned over emX devices changing to igbX at one point.)

Jan 28 2015, 7:13 PM
jfv accepted D1640: Refactor network stack state separate from VSI state.

Thanks Ryan, am happier with this.

Jan 28 2015, 1:15 AM

Jan 21 2015

jfv retitled D1580: Revamp ixgbe into seperate if_ix and if_ixv drivers from to Revamp ixgbe into seperate if_ix and if_ixv drivers.
Jan 21 2015, 10:28 PM

Jan 6 2015

jfv added a comment to D1383: Break out RSS init path into sys/net; inet4 code in sys/netinet/; inet6 code in sys/netinet6/.

Changes in my code are trivial, and fine by me.

Jan 6 2015, 10:41 PM