- User Since
- Dec 1 2014, 9:00 PM (359 w, 2 d)
Dec 13 2020
Aug 3 2015
Cool, surprised this wasn't caught earlier :)
Jul 24 2015
Thanks for getting this in Eric.
The block of code that Sean asked about is basically something the hardware
team said needed to be added, they gave me no details, this is often the way
it goes Sean, sorry :)
Jun 26 2015
Code got added because Jeff saw link changes not being visible in a VM,
I do not recall for sure if he tested a desk build, but things are certainly
broken without the code... so long as you've done basic sanity testing I
would commit it.
Jun 6 2015
Jun 5 2015
Jun 3 2015
The shared code changes just require some legal stuff if they are taken back into our code base, if you leave it as is we can cope with that later, its not like the E1000 shared code has a lot of churn at this point.
Thanks for all the work you put into this Sean, go for it :)
Jun 2 2015
Jun 1 2015
May 15 2015
We removed these additional task creations with the intent purpose of
reducing lock contention for a customer as I recall, so unless you have a
good reason to add it back I would oppose doing so.
May 11 2015
Correct a couple minor points in the last revision.
May 8 2015
Remove x550 device that is not yet available. Also remove unneeded shared code prototype,
and some added whitespace.
May 7 2015
Apr 29 2015
Looks good, thanks much John!
Apr 21 2015
Change E1000_MRQC_ENABLE_RSS_4Q to E1000_MRQC_ENABLE_RSS_8Q, and the comment
Mar 27 2015
Mar 11 2015
Mar 6 2015
Mar 3 2015
The code is not acceptable as is right now, Eric and I are discussing changes.
Feb 27 2015
Feb 25 2015
Feb 18 2015
Jan 29 2015
can't wait to see the infrastructure in place :)
Looks good. Again, will need real world testing when we have infrastructure.
Don't see any problems.
Jan 28 2015
Let's not mention Linux in our comments, either say nothing or think of something else :)
Don't see any issues, of course the proof will come in the actual use when we
have the infrastructure :)
Thanks Ryan, am happier with this.
Jan 21 2015
Jan 6 2015
Changes in my code are trivial, and fine by me.