Full 32bit flowid for igb(4)
ClosedPublic
Actions

Authored by hiren on Apr 14 2015, 9:53 PM.

Details

Reviewers

jfv
erj
adrian

Commits

rS281838: For igb(4), when we are doing multiqueue, we are all setup to have full 32bit

Summary

For igb(4), when we are doing multiqueue, we are all setup to have full
32bit RSS hash from the card. We do not need to hide that under "ifdef RSS" and
should expose that by default so others lile lagg(4) can use that and avoid
hashing the traffic by itself.

Test Plan

I've checked with netstat -R that now we are getting full flowids with the
patch on I350 igb chipset that I have.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hiren updated this revision to Diff 4832.Apr 14 2015, 9:53 PM

hiren retitled this revision from to Full 32bit flowid for igb(4).

hiren updated this object.

hiren edited the test plan for this revision. (Show Details)

hiren added a reviewer: adrian.

hiren added a subscriber: network.

Herald added a subscriber: imp. · View Herald TranscriptApr 14 2015, 9:53 PM

hiren added reviewers: jfv, erj.Apr 14 2015, 9:55 PM

hiren removed a subscriber: imp.

j-nitrology.com added a subscriber: j-nitrology.com.Apr 14 2015, 10:17 PM

@erj / @jfvogel : can one of you please look at this?

I'd want to wait for a comment from Jack, but this looks good just by looking at it.

Change E1000_MRQC_ENABLE_RSS_4Q to E1000_MRQC_ENABLE_RSS_8Q, and the comment
to :

/*
 * MRQC: Multiple Receive Queues Command
 *    - Set queuing to RSS control, number depends on the device.
 */

Second, delete the notdef block, I don't like undefined cruft cluttering up the code.

Addressing comments from jfv@
Updating MRQC assignment.
Removing '#ifdef notyet' block for UDP.

jfv accepted this revision.Apr 21 2015, 6:28 PM

jfv edited edge metadata.

This revision is now accepted and ready to land.Apr 21 2015, 6:28 PM

Closed by commit rS281838: For igb(4), when we are doing multiqueue, we are all setup to have full 32bit (authored by hiren). · Explain WhyApr 21 2015, 9:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

e1000/

if_igb.c

85 lines

Diff 4944

View Options

head/sys/dev/e1000/if_igb.c

Full 32bit flowid for igb(4)ClosedPublicActions