Page MenuHomeFreeBSD

Full 32bit flowid for igb(4)
ClosedPublic

Authored by hiren on Apr 14 2015, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 28, 10:06 AM
Unknown Object (File)
Dec 9 2022, 4:25 AM
Unknown Object (File)
Nov 27 2022, 1:49 AM
Unknown Object (File)
Apr 22 2017, 2:31 PM
Unknown Object (File)
Apr 1 2017, 10:04 AM
Unknown Object (File)
Dec 14 2016, 3:55 PM
Unknown Object (File)
Nov 30 2016, 2:10 PM
Unknown Object (File)
Oct 3 2016, 11:42 AM

Details

Summary

For igb(4), when we are doing multiqueue, we are all setup to have full
32bit RSS hash from the card. We do not need to hide that under "ifdef RSS" and
should expose that by default so others lile lagg(4) can use that and avoid
hashing the traffic by itself.

Test Plan

I've checked with netstat -R that now we are getting full flowids with the
patch on I350 igb chipset that I have.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hiren retitled this revision from to Full 32bit flowid for igb(4).
hiren updated this object.
hiren edited the test plan for this revision. (Show Details)
hiren added a reviewer: adrian.
hiren added a subscriber: network.
hiren removed a subscriber: imp.

@erj / @jfvogel : can one of you please look at this?

I'd want to wait for a comment from Jack, but this looks good just by looking at it.

Change E1000_MRQC_ENABLE_RSS_4Q to E1000_MRQC_ENABLE_RSS_8Q, and the comment
to :

/*
 * MRQC: Multiple Receive Queues Command
 *    - Set queuing to RSS control, number depends on the device.
 */

Second, delete the notdef block, I don't like undefined cruft cluttering up the code.

hiren edited edge metadata.

Addressing comments from jfv@
Updating MRQC assignment.
Removing '#ifdef notyet' block for UDP.

jfv edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 6:28 PM
This revision was automatically updated to reflect the committed changes.